1331661 - Enable the quotes rule for eslint

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

This rule will "enforce the consistent use of either backticks, double, or single quotes (quotes)"

We will use the following configuration:
"quotes": ["error", "double", { "avoidEscape": true, "allowTemplateLiterals": true }],

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1331661 - Enable the 'quotes' rule for eslint and fix most of the errors with --fix.

Review commit: https://reviewboard.mozilla.org/r/105172/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/105172/

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1331661 - Manually fix the remaining 'quotes' errors for eslint.

Review commit: https://reviewboard.mozilla.org/r/105174/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/105174/

Comment 3

[:Gijs (he/him)]

Comment on attachment 8827508 [details]
Bug 1331661 - Manually fix the remaining 'quotes' errors for eslint.

https://reviewboard.mozilla.org/r/105174/#review105986

Comment 4

[:Gijs (he/him)]

Comment on attachment 8827507 [details]
Bug 1331661 - Enable the 'quotes' rule for eslint and fix most of the errors with --fix.

https://reviewboard.mozilla.org/r/105172/#review105988

r=me on the eslintrc change. I'll assume that for something as boring as this, --fix has done the right thing, iff try is happy.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8827507 [details]
Bug 1331661 - Enable the 'quotes' rule for eslint and fix most of the errors with --fix.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/105172/diff/1-2/

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8827508 [details]
Bug 1331661 - Manually fix the remaining 'quotes' errors for eslint.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/105174/diff/1-2/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8cb53491dd1c
Enable the 'quotes' rule for eslint and fix most of the errors with --fix. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/4900b6c465ca
Manually fix the remaining 'quotes' errors for eslint. r=Gijs

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8cb53491dd1c
https://hg.mozilla.org/mozilla-central/rev/4900b6c465ca