Closed
Bug 1331928
Opened 8 years ago
Closed 3 years ago
Remove AssertDisplayItemData
Categories
(Core :: Web Painting, defect, P3)
Core
Web Painting
Tracking
()
RESOLVED
WORKSFORME
| Performance Impact | low |
People
(Reporter: bas.schouten, Assigned: bas.schouten)
References
(Blocks 1 open bug)
Details
(Keywords: perf:resource-use)
Attachments
(1 file)
|
8.60 KB,
patch
|
Details | Diff | Splinter Review |
Markus indicates this has served its purpose, and it's currently only having a small negative performance impact, so we should probably remove this.
Markus, are we sure removing this won't cause a UAF in the real world instead of a crash?
Attachment #8827893 -
Flags: review?(mstange)
|
||
Comment 1•8 years ago
|
||
(In reply to Bas Schouten (:bas.schouten) from comment #0)
> Markus, are we sure removing this won't cause a UAF in the real world
> instead of a crash?
That's a good point. It probably will :(
|
|
||
Updated•8 years ago
|
Attachment #8827893 -
Flags: review?(mstange)
|
|
||
Comment 2•8 years ago
|
||
(In reply to Bas Schouten (:bas.schouten) from comment #0)
> Markus, are we sure removing this won't cause a UAF in the real world
> instead of a crash?
Once the DisplayItemData objects are in the presshell arena (bug 1330570), frame poisoning should prevent these UAFs from being exploitable.
Depends on: 1330570
|
||
Updated•7 years ago
|
Priority: -- → P3
|
||
Updated•3 years ago
|
Performance Impact: --- → ?
|
||
Comment 3•3 years ago
|
||
Bas, is this still relevant?
|
Assignee | |
Comment 4•3 years ago
|
||
This code no longer exists.
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Flags: needinfo?(bas)
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•