Closed Bug 1332036 Opened 3 years ago Closed 3 years ago

Avoid the sync IPC message added in bug 1331676

Categories

(Core :: Canvas: WebGL, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: ehsan, Assigned: ehsan)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

In bug 1331676 I added a sync IPC message at content process startup but bug 1303096 is removing those existing ones.  I'll rework this to remove the sync IPC I added after bug 1303096 lands.
Attachment #8836275 - Flags: review?(dvander)
Comment on attachment 8836275 [details] [diff] [review]
Avoid the sync IPC message added in bug 1331676

Review of attachment 8836275 [details] [diff] [review]:
-----------------------------------------------------------------

It looks pretty awkward to put all of this in the process argv. Can we push it down as an async initialization message instead?
Attachment #8838595 - Flags: review?(dvander)
Attachment #8836275 - Attachment is obsolete: true
Attachment #8836275 - Flags: review?(dvander)
Ping?
Comment on attachment 8838595 [details] [diff] [review]
Avoid the sync IPC message added in bug 1331676

Review of attachment 8838595 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, sorry I completely missed this in my dashboard.
Attachment #8838595 - Flags: review?(dvander) → review+
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ffb43ea033eb
Avoid the sync IPC message added in bug 1331676; r=dvander
https://hg.mozilla.org/mozilla-central/rev/ffb43ea033eb
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
thanks for landing this, talos is showing performance improvements:
== Change summary for alert #5327 (as of March 07 2017 13:56 UTC) ==

Improvements:

  3%  sessionrestore linux64 pgo e10s     640.79 -> 619.92
  3%  ts_paint linux64 pgo e10s           1093.33 -> 1066

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=5327
(In reply to Joel Maher ( :jmaher) from comment #8)
> thanks for landing this, talos is showing performance improvements:
> == Change summary for alert #5327 (as of March 07 2017 13:56 UTC) ==
> 
> Improvements:
> 
>   3%  sessionrestore linux64 pgo e10s     640.79 -> 619.92
>   3%  ts_paint linux64 pgo e10s           1093.33 -> 1066
> 
> For up to date results, see:
> https://treeherder.mozilla.org/perf.html#/alerts?id=5327

\o/
You need to log in before you can comment on or make changes to this bug.