Closed Bug 1332114 Opened 3 years ago Closed 3 years ago

[debugger.html] Hold the new debugger in Aurora

Categories

(DevTools :: Debugger, defect)

Product:
DevTools
Component:
Debugger
Type:
defect
Priority:
Not set

Tracking

(firefox51 unaffected, firefox52 fixed, firefox53 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 53
Tracking Flags:
Tracking Status
firefox51 --- unaffected
firefox52 --- fixed
firefox53 --- fixed

People

(Reporter: clarkbw, Assigned: jlast)

References

Details

Attachments

(1 file, 1 obsolete file)

dbg-flag3.patch
1.40 KB, patch
jryans
: review+
jcristau
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
In bug 1300861 we turned on the new debugger for Nightly builds and in bug 1294139 we turned on the new debugger for all channels.  However several things have changed and we need to roll back our plans for releasing the new debugger.

Please hold the pref change that defaults to the new debugger in the Aurora channel. 

This will give us more time we need to land a few features we knew we were missing but were hoping would be further along by this point.  These missing features are things like Watch Expressions and Hover in the Editor to inspect.
Attached patch dbg-flag2.patch (obsolete) — — Splinter Review
Attachment #8828599 - Flags: review?(jryans)
Attached patch dbg-flag3.patch — — Splinter Review 
[Feature/Bug causing the regression]: 1294139

[User impact if declined]:
We would enable the new debugger frontend in beta. 
We expected to have additional features in the frontend at this point.


[Is this code covered by automated tests?]: no

[Has the fix been verified in Nightly?]: no

[Needs manual test from QE? If yes, steps to reproduce]: 

I am not sure how to manually test the preference. as it requires a beta release.

[List of other uplifts needed for the feature/fix]:

[Is the change risky?]:

no.

[Why is the change risky/not risky?]:

If the new debugger frontend is enabled it is not a bad experience.


[String changes made/needed]:
Attachment #8828599 - Attachment is obsolete: true
Attachment #8828599 - Flags: review?(jryans)
Attachment #8828602 - Flags: review?(jryans)
Attachment #8828602 - Flags: approval-mozilla-aurora?
Comment on attachment 8828602 [details] [diff] [review]
dbg-flag3.patch

Review of attachment 8828602 [details] [diff] [review]:
-----------------------------------------------------------------

Looks correct to me!
Attachment #8828602 - Flags: review?(jryans) → review+
Comment on attachment 8828602 [details] [diff] [review]
dbg-flag3.patch

pref off new debugger for aurora52
Attachment #8828602 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox51: --- → unaffected
status-firefox53: --- → wontfix
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
This needs to land in 53 as well, it just happened to land in 52 first...
Status: RESOLVED → REOPENED
status-firefox53: wontfix → affected
Keywords: checkin-needed
Resolution: FIXED → ---
Target Milestone: Firefox 52 → Firefox 53
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/mozilla-inbound/rev/43f6ae2d0847
Turn off new debugger in all channels. r=jryans
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/43f6ae2d0847
Status: REOPENED → RESOLVED
Closed: 3 years ago → 3 years ago
status-firefox53: affected → fixed
Resolution: --- → FIXED
Blocks: 1294139
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.