133215 - Quick search does not work for "sender" with quick search field label translated

Status: VERIFIED FIXED

(MailNews Core :: Internationalization, defect, P1)

Description

[Rainer Bielefeld]

Mozilla/5.0 (Windows; U; Win98; de-AT; rv:0.9.9) Gecko/20020311 (04)
In my rv 0.9.7 , 0.9.8, 0.9.9 I have different search results with different
language settings (preferences/appearence):
1. mail news
2. newsgroup 3de.comm.software.mozilla" 
3. search for "Subject or Sender Contains"

different results:
search for           Language "ge"     Language "US" 
Wolfgang             no result !!      All senders containing "Wolfgang"
Bauer                no result !!      All senders containing "Bauer"
Wolfgang B           no result !!      All senders containing "Wolfgang B"
Bauer Wolfgang       no result !!      no result

!! means: unexpected result

I can
- switch the bug ON  by change to "german language"
- switch the bug OFF by change to "US"
(appearance/language)

Would be interesting to know: only Problem with german language Package or in
all not-US-Packages?

Comment 1

[marina]

i don't think that non-ascii search in newsgroup is implemented yet.

Comment 2

[nhottanscp]

Right, I think there is a separate bug about news search. 
Is this working with pop and imap?

Comment 3

[marina]

POP and Local serach is working for non-ascii chars, IMAP will bring all matches
for "ü" with u (which i believe is as designed for IMAP search). In fact i am
trying to find a dup for the news search bug ( i remember filing it a while ago,
still quering..)

Comment 4

[nhottanscp]

bug 64579 - Seaching for int chars in news doesn't work

Comment 5

[Rainer Bielefeld]

It is a Problem of _all_ folders, inbox, send .... too.

Charset might be a good Idea.


The mail with following Header has been found in inbox with search for (sender)
"Welle"


From - Sat Mar 23 10:35:15 2002
X-UIDL: 30e241af4e48b22b
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00000000
Return-Path: <[e-mail]>
Received: from castor.dwelle.de ([194.55.30.50]) by mailin03.sul.t-online.de
	with smtp id 16ohxG-1o9klkc; Sat, 23 Mar 2002 10:36:54 +0100
Received: from 192.168.245.40 by castor.dwelle.de (InterScan E-Mail VirusWall
NT); Sat, 23 Mar 2002 10:04:27 +0100
Received: by voltaire.dwelle.de (Postfix on SuSE Linux 7.0 (i386))
	id 74AC6B67B0; Sat, 23 Mar 2002 09:57:08 +0100 (CET)
Delivered-To: [e-mail]
Received: by voltaire.dwelle.de (Postfix on SuSE Linux 7.0 (i386), from userid 28)
	id 59039B67EE; Sat, 23 Mar 2002 09:57:08 +0100 (CET)
Delivered-To: [e-mail]
Received: from heine.dwelle.de (unknown [192.168.244.250])
	by voltaire.dwelle.de (Postfix on SuSE Linux 7.0 (i386)) with ESMTP id 0A6A4B67B0
	for <nachrichten@voltaire>; Sat, 23 Mar 2002 09:57:08 +0100 (CET)
Received: from [194.55.18.178] (9853 bytes) by heine.dwelle.de
	via smail-3.2.0.112 (sender: <[e-mail]>) 
	id <[e-mail]>
for <[e-mail]>; Sat, 23 Mar 2002 10:03:13 +0100 (CET)
	(Smail-3.2.0.112 2001-Feb-5 #7 built 2001-Aug-13)
Received: from lessing.dwelle.de ([194.55.18.208])
 by vgate2.dwelle.de (NAVIEG 2.1 bld 63) with SMTP id M2002032310031509915
 for <[e-mail]>; Sat, 23 Mar 2002 10:03:15 +0100
From: Deutsche Welle <[e-mail]>
To: [e-mail]
Subject: Nachrichten, 23.3.2002, 09:00 Uhr UTC
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=iso-8859-1
Date: Sat, 23 Mar 2002 10:03:15 +0100
Message-Id: <M2002032310031509915>
Sender: [e-mail]
Precedence: bulk




The mail with following Header has _not been Found in inbox with search for
(sender) "Kruse"

From - Tue Jul 24 10:43:34 2001
Return-Path: <[e-mail]>
Received: from krusegmbh.de (333100009426-0001@[62.224.144.104]) by
fwd07.sul.t-online.com
	with esmtp id 15OxVU-0sUyyOC; Tue, 24 Jul 2001 10:25:32 +0200
Message-ID: <[e-mail]>
Date: Tue, 24 Jul 2001 10:28:30 +0200
From: [e-mail] (Zentrale Kruse)
X-Mailer: Mozilla 4.75 [de] (Win95; U)
X-Accept-Language: de
MIME-Version: 1.0
To: [e-mail]
Subject: Re: BESTELLUNG / Frau =?iso-8859-1?Q?R=F6mer?=
References: <[e-mail]>
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
X-Sender: [e-mail]
X-Mozilla-Status: 8013
X-Mozilla-Status2: 00000000
X-UIDL: 1143f4c80fccc6ff

Comment 6

[marina]

reporter, what is your mail server? The non-ascii search is working on Local and
POP mail for all headers, if your server is IMAP then it is expected to bring
back matches that contain ascii and nonascii chars. Could you please attach the
message instead of copying its source? Thanks.

Comment 7

[Rainer Bielefeld]

I'm a little helpless how to attatch an _original_  mail out of my inbox, wo I
will send severals to all of the mailing list.

I think, diskussion would be much easier if all interested would use the same
newsgrup and to be shure to have the same supposition: same newsserver.
I propose the one of my test:
news.t-online.de  (server)
119  (port)
de.comm.software.mozilla (newsgroup)
So it would be easier to compare search results!

Comment 8

[marina]

Rainer, i am not authorized to use this server... so no luck mapping it. But if
we are talking about search in headers in newsgroups it is not working right
now.To attach your mail: save your message in .eml format (file|save as |file).
Then inside the bug report go to the link "Create an attachment". in the
following page browse and find a path where you saved your .eml file (your
message) and attach it chosing radio button for plain text format, Submit and
you're done!,

Comment 9

[Rainer Bielefeld]

Attachment: email I coulf find in my INBOX

email I coulf find in my INBOX with search for (sender) "Welle"

Comment 10

[Rainer Bielefeld]

Attachment: email I could not find in my INBOX

email I could _not_ find in my INBOX with Quicksearch for sender "Zentrale"

Comment 11

[Rainer Bielefeld]

I do not belive that this bug depends on bug 64579.

The Problem is *not*, that special chars cannot be found.
The Problem is, that iallways in the same folder (or newsgroup) a sender with
name "Zentrale" will not be found, but a subject with  "Zentrale" will be found,
if Language "German" is selected.
(And not any Problem with Language "US" selected"
I think id would be senseful to try to reproduce the Problem in accordance to my
messages.
Sorry, in the fist message is a mistake, the name of the newsgroup is
"de.comm.software.mozilla", not "3de.comm.software.mozilla"

Comment 12

[marina]

Rainer, let me clarify the steps:
- set Language to German ( you mean language for browser in Preferences?
Edit|Pref\Languages\De (add it and place at the top of the list), right?;
- select a newsgroup;
- go to Search|Messages and search for a sender "Welle" or "Zentrale";
//those two senders names have ascii only chars and should be found ( you won't
be able to find a sender in the newsgroup with non-ascii chars in the sender's
name);
I copied your two emails to my local folder and i am able to find both by the
sender criteria... I don't know how else i can reproduce this bug...
Naoki, do you have any ideas?

Comment 13

[Rainer Bielefeld]

Hi Marina,

no, the way to repoduce the bug is *completely* different from your description,
it seems that my description was not so very complete.!

Here the steps:

0. load German language package if not available for your mozilla
1. EDIT/PREFERENCES/APPEARANCE/LANGUAGES-CONTENT
   Change to "Deutsch"
2. colose mozilla
3. restart mozilla 
   now you have German language
4. go to mail-client
5. select folder
5. write search-words into quick-search-line
   Quicksearch means:
   http://home.t-online.de/home/Bielefeld__Buss_oHG/mozilla/quicksearch.jpg



My Idea with the t-online-newsserver for tests with same database was not so
very good, but what is with
secnews.netscape.com
(port 119)

Let us search for posting:

From: michael lefevre <[e-mail]>
Newsgroups: netscape.public.mozilla.mail-news
Subject: Re: SMTP authentication
Date: 26 Mar 2002 12:20:05 GMT
Lines: 11
Message-ID: <a7pp1l$n9otf$[e-mail]>
References: <[e-mail]>
<a7n2t7$lkhkh$[e-mail]>
<[e-mail]>
Reply-To: [e-mail]
NNTP-Posting-Host: rift.ukshells.co.uk (217.10.142.100)
X-Trace: fu-berlin.de 1017145205 24437679 217.10.142.100 (16 [106624])
User-Agent: slrn/0.9.7.3 (Linux)
Xref: secnews.netscape.com netscape.public.mozilla.mail-news:22068




My results :
different results:
search for           Language "ge"     Language "US" 
michael              no match  !!      All senders containing "michael"
lefevre              no match  !!      All senders containing "lefevre"
michael l            no match  !!      All senders containing "michael l"
michael lefevre      no match  !!      All senders containing "michael lefevre"
lefevre michael      no match          no match  

!! means: unexpected result

I can
- switch the bug ON  by change to "german language"
- switch the bug OFF by change to "US"
(appearance/language)


I hope I succeeded in giving a better description for the bug

Comment 14

[Rainer Bielefeld]

Newsgroup for suggested tests 
(seeAdditional Comment #13 From Rainer Bielefeld 2002-03-26 23:31 -------)
netscape.public.mozilla.mail-news

Comment 15

[marina]

so, you are talking about 0.9.9 branch with german language pack. Now i
understand, thanks for clarification! Do all 0.9.8 and 0.9.9 branches with "de"
language pack give the same( unexpected) results?

Comment 16

[Rainer Bielefeld]

I have this bug in all my versions 0.9.7, 0.9.8, 0.9.9. (please see my first
message!)

Today I tried additionally 0.9.8 with the french language package, and I was
able to reproduce the bug: in all cases the exactly same reaction for
quicksearch as with the german language package.

In the french Version for 0.9.8, the "advanced search" did not work (this only
for infomation, shuod not be examined under this but-id, because it might be
that this is obsolete for 0.9.9)

Comment 17

[Rainer Bielefeld]

Fine Window:
http://www.mozilla.org/mailnews/specs/qksearch/#Results
shows the search for sender "fred", which does not work with french and german
languaguage pack.
I read some discussions in  netscape.public.mozilla.mail-news  concerning Quick
Search, and now I have the Question: What are the differences between
- normal search
- quick search
- search as described here for the bug

Comment 18

[Rainer Bielefeld]

Today I tried additionally 0.9.8 with the spanish language package
Mozilla/5.0 (Windows; U; Win98; es-HN; rv:0.9.8) Gecko/20020204
and I was
able to reproduce the bug: in all cases the _exactly_ same reaction for
quicksearch as with the german language package.

Here were no problems with th normal search-window as described for the french
language package under
------- Additional Comment #16 From Rainer Bielefeld 2002-03-27 22:58 -------

Comment 19

[Robert Kaiser]

I'm seeing this too on my de-AT build. (Note: I didn't try if en-US shows
correct results currently)

Interestingly, If you go into "advanced" serch window, it returns the right results.

The problem seems to be the following:
1) The Quick serch bar actually does work
2) The search bar works right for subject matches
3) Instead of returning matches for "sender" ("Absender"), it returns matches
for "to or cc" ("An oder CC")

I'm not sure why this is happening but it's what my looking into this is showing.

Comment 20

[Rainer Bielefeld]

Yes, I have absolutely the same Results as  Robert Kaiser with "da-AT"

Comment 21

[nhottanscp]

Tao, who takes care lang-pack issues?

Comment 22

[tao]

Since this problem appears in both French and German langpacks, it's unlikey a
langpack problem. I suspect it is an i18n issue in the search functionality.
Who is the module owner, naving?

Comment 23

[nhottanscp]

194 if (isSender.search("Sender") != -1)
That line depends on the English string in the .property. I think what happens
for the localized builds is that recepient is searched instead of sender.
The code should not depend on the English word of the .property. It has to check
 the current folder selection to decide the search criteria.

nsbeta1, because it affects all localized builds.

http://lxr.mozilla.org/seamonkey/source/mailnews/base/resources/content/searchBar.js#194
176 function createSearchTerms()
177 {
178 var nsMsgSearchScope = Components.interfaces.nsMsgSearchScope;
179 var nsMsgSearchAttrib = Components.interfaces.nsMsgSearchAttrib;
180 var nsMsgSearchOp = Components.interfaces.nsMsgSearchOp;
181 182 gSearchSession.clearScopes();
183 var searchTerms = gSearchSession.searchTerms;
184 var searchTermsArray =
searchTerms.QueryInterface(Components.interfaces.nsISupportsArray);
185 searchTermsArray.Clear();
186 gSearchSession.addScopeTerm(nsMsgSearchScope.offlineMail,
GetThreadPaneFolder());
187 var term = gSearchSession.createTerm();
188 var value = term.value;
189 if (value)
190 value.str = gSearchInput.value;
191 gSearchSession.addSearchTerm(nsMsgSearchAttrib.Subject,
nsMsgSearchOp.Contains, value, false, null);
192 var isSender = new String;
193 isSender = gSearchCriteria.getAttribute("value");
194 if (isSender.search("Sender") != -1)
195 gSearchSession.addSearchTerm(nsMsgSearchAttrib.Sender,
nsMsgSearchOp.Contains, value, false, null);
196 else
197 gSearchSession.addSearchTerm(nsMsgSearchAttrib.ToOrCC,
nsMsgSearchOp.Contains, value, false, null); 
198 }

Comment 24

[Navin Gupta]

yes, it should look for folder flag before searching for sender /recipient. 
I can attach a fix if we are going to take it for 1.0

Comment 25

[nhottanscp]

I think this is important because we cannot translate the string
"Subject or Sender contains:", the string is visible in the UI.

Comment 26

[ji]

Change Severity to Major. With this problem, on all the localized builds, if we 
localize quick search field label on 3-pane, search function will be broken.

Comment 27

[Navin Gupta]

Attachment: proposed

Use folder flags to determine sender/recipient.

Comment 28

[Navin Gupta]

Attachment: proposed fix

Use folder flags to determine sender/recipient.

Comment 29

[Navin Gupta]

David, can you review ? thx. 

Comment 30

[David :Bienvenu]

I don't think you should use ToorCC, since we only display the To: header field
i.e., the recipient.

Comment 31

[David :Bienvenu]

Comment on attachment 77107 [details] [diff] [review]
proposed fix

but I guess that's a different issue - r=bienvenu, despite that.

Comment 32

[Sean Su]

Comment on attachment 77107 [details] [diff] [review]
proposed fix

r=ssu

Comment 33

[scottputterman]

Adding adt1.0.0 nomination.

This is high impact since Quick Search is a very visible mail feature.  It
should work on localized builds.

Comment 34

[tao]

> Adding adt1.0.0 nomination.
>
>This is high impact since Quick Search is a very visible mail feature.  It
>should work on localized builds.

I second Scott's vote. I used this feature almost daily. CC jhooker.

Comment 35

[Navin Gupta]

Comment on attachment 77107 [details] [diff] [review]
proposed fix

carrying fwd r=bienvenu

Comment 36

[Jaime Rodriguez, Jr.]

adt1.0.0+ (on ADT's behalf) approval for checkin to 1.0.

Comment 37

[Asa Dotzler [:asa]]

Comment on attachment 77107 [details] [diff] [review]
proposed fix

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 38

[Navin Gupta]

fixed

Comment 39

[Gayatri Rimola]

Changing component to Internationalization.

Comment 40

[marina]

i edited messenger.properties and messenger.dtd files changing as Navin
suggested the string "Subject or Sender contains" to "Subject and somebody
contains" and the search works as it used to work prior to the string change.
Navin, do i have to change the string to a non-ascii string when editing?
Remember this didn't work when i was verifying bug # 22994, cc'ing rchen for
suggestions.I can not do the easy verification by just using the langpacks
because they do not work for French and German ( they both have remarks "need
update") and can not be selected therefore can not be used.

Comment 41

[Navin Gupta]

yes, you could try non-ascii string also.

Comment 42

[marina]

here are the results: when i change the "sender" string to a nonsense string
with 3 accented char ( alt+o+ 233) in messenger.dtd only and then  bring up the
mail this string is missing in the UI, the UI string reads as follows "Subject
or contains". When i edit both files ( messenger.dtd and messenger.properties) i
can not open mail at all, i get an XML error...

Comment 43

[ji]

How about using pseudo localized build to verify this?
The fix was checked in 04/04, Ray's pseudo localized build should contain the fix.

Comment 44

[marina]

Navin, here are the results for testing with the ja lang pack, from the email
from Rui Xu: "I just checked the quick search for the subject and sender name on
2002-04-09-10 trunk with and without Japanese langpack, it works fine in both
cases with Japanese, Chinese and Korean characters.
And, it also works on 2002-04-16 trunk with Japanese and Chinese characters,
(not using Japanese langpack)."
Let me know if you need more testing.Thanks.

Comment 45

[Navin Gupta]

marina, I think it is good enough. This has been checked into branch.