1332164 - Startup Crash in js::FrameIter::settleOnActivation [Mac]

Status: RESOLVED WORKSFORME

(Thunderbird :: General, defect)

Description

[Wayne Mery (:wsmwk)]

Multiple Mac versions.
#12 Mac crash for 51.0b1. #20 for 45.6.0

report bp-142eb437-7dc6-4e9e-8185-bcdff2170114.
user writes "crash at open and impossible to launch"
 0 	XUL	js::FrameIter::settleOnActivation()	js/src/vm/Stack.h:789
1 	XUL	js::FrameIter::operator++()	js/src/vm/Stack.cpp:718
2 	XUL	js::SavedStacks::insertFrames	js/src/vm/SavedStacks.cpp:1301
3 	XUL	js::SavedStacks::saveCurrentStack	js/src/vm/SavedStacks.cpp:1103
4 	XUL	JS::CaptureCurrentStack	js/src/jsapi.cpp:6619
5 	XUL	mozilla::dom::exceptions::CreateStack	dom/bindings/Exceptions.cpp:701
6 	XUL	mozilla::dom::GetCurrentJSStack(int)	dom/bindings/Exceptions.cpp:233
7 	XUL	mozilla::dom::Exception::Initialize(nsACString_internal const&, nsresult, nsACString_internal const&, nsIStackFrame*, nsISupports*)	dom/base/DOMException.cpp:425
8 	XUL	mozilla::dom::Exception::Exception(nsACString_internal const&, nsresult, nsACString_internal const&, nsIStackFrame*, nsISupports*)	dom/base/DOMException.cpp:220
9 	XUL	mozilla::dom::CreateException(JSContext*, nsresult, nsACString_internal const&)	dom/bindings/Exceptions.cpp:210
10 	XUL	mozilla::dom::Throw(JSContext*, nsresult, nsACString_internal const&)	dom/bindings/Exceptions.cpp:166
11 	XUL	XPCThrower::ThrowBadResult(nsresult, nsresult, XPCCallContext&)	js/xpconnect/src/XPCThrower.cpp:127
12 	XUL	XPCWrappedNative::CallMethod(XPCCallContext&, XPCWrappedNative::CallMode)	js/xpconnect/src/XPCInlines.h:555

Comment 1

[Wayne Mery (:wsmwk)]

So far, no crashes for 52.0xx or 53.xx.

Comment 2

[Wayne Mery (:wsmwk)]

still no crashes yet for version 52.

Comment 3

[Wayne Mery (:wsmwk)]

(In reply to Wayne Mery (:wsmwk, NI for questions) from comment #2)
> still no crashes yet for version 52.

some 52.0b1
bp-00ec3cfc-457b-4703-8026-8d4ed2170215 2017-02-15 12:41:29 	52.0b1 	20170126105536 	Mac OS X 	10.12.2 16C67
bp-abd4983d-345d-4654-b9e0-0dd7f2170131 2017-01-31 15:49:59 	52.0b1 	20170126105536 	Windows NT 	10.0.10586
bp-82166d6e-f115-4bce-9c1d-c86a32170131 2017-01-31 07:03:43 	52.0b1 	20170126105536 	Windows NT 	10.0.10586 

but so far no 52.0b2 after we have reached 25k users

Comment 4

[Phoenix]

Resolved per whiteboard

Comment 5

[Wayne Mery (:wsmwk)]

js::FrameIter::settleOnActivation  is #160 crash for Thunderbird 52.2.1 (beta again fails to predict release crash rates)

And perhaps related js::ActivationIterator::operator++ #79 crash for Thunderbird 52.2.1, for example bp-127d93b9-869f-4cc0-9bdb-85dfa0170802

And this may all be a continuation of Bug 1332161 - Startup crash in js::NativeGetProperty [Mac]

Comment 6

[Wayne Mery (:wsmwk)]

Shortly after comment 5 crash rate on (I assume) 52.x dropped.  And I recently also closed bug 1332161.
THere are currently almost no Mac s::FrameIter::settleOnActivation crashes for current versions.

js::ActivationIterator::operator++ is almost all same person (libor) from bp-e45c1bf5-269f-4000-9e4d-e79280171116 for 52.4.0.  I'm betting it will be gone in 52.5.0.