add BUG_COMPONENT to extensions/* files

RESOLVED FIXED in Firefox 54

Status

()

Core
General
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: jmaher, Assigned: jmaher)

Tracking

unspecified
mozilla54
Points:
---

Firefox Tracking Flags

(firefox54 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

a year ago
$ ./mach file-info bugzilla-component extensions/**
UNKNOWN
  extensions/auth
  extensions/build.mk
  extensions/confvars.sh
  extensions/cookie
  extensions/gio
  extensions/moz.build
  extensions/moz.configure
  extensions/permissions
  extensions/pref
  extensions/spellcheck
  extensions/universalchardet


adding BUG_COMPONENT helps with research on files and other tools which interface with the source.  My reason is to ensure when I am working on an intermittent test case that I can find a proper bug component for the test case or root cause if it is obvious.

From some digging in dxr, it looks like each of these subdirs belong to different components.
(Assignee)

Comment 1

a year ago
Created attachment 8828485 [details] [diff] [review]
add BUG_COMPONENT to extensions/*

Here is what this patch ends up with:

$ ./mach file-info bugzilla-component extensions/**
Core :: AutoConfig (Mission Control Desktop)
  extensions/pref
Core :: DOM
  extensions/permissions
Core :: General
  extensions/build.mk
  extensions/confvars.sh
  extensions/gio
  extensions/moz.build
  extensions/moz.configure
Core :: Internationalization
  extensions/universalchardet
Core :: Networking
  extensions/auth
Core :: Networking: Cookies
  extensions/cookie
Core :: Spelling checker
  extensions/spellcheck


I am not sure about the extensions/gio/* folder.  I took guesses on many of the files here, some have no specific history that could indicate what component they belong to.
Assignee: nobody → jmaher
Status: NEW → ASSIGNED
Attachment #8828485 - Flags: review?(overholt)
gio is for gvfs (bug 402892).  It might be either widget:gtk or XPCOM.
(Assignee)

Comment 3

a year ago
Created attachment 8829208 [details] [diff] [review]
add BUG_COMPONENT to extensions/*

updated with gio/* as Widget: Gtk
Attachment #8828485 - Attachment is obsolete: true
Attachment #8828485 - Flags: review?(overholt)
Attachment #8829208 - Flags: review?(overholt)
Comment on attachment 8829208 [details] [diff] [review]
add BUG_COMPONENT to extensions/*

Review of attachment 8829208 [details] [diff] [review]:
-----------------------------------------------------------------

Everything looks good except for the pref/ one. I don't know if this should be an r- or an r+ for that, sorry :)

::: extensions/pref/moz.build
@@ +7,5 @@
>  
>  DIRS += ['autoconfig']
> +
> +with Files('**'):
> +    BUG_COMPONENT = ('Core', 'AutoConfig (Mission Control Desktop)')

I *think* this should be Core:: Preferences: Backend but bsmedberg would know for sure.
Attachment #8829208 - Flags: review?(overholt)
Attachment #8829208 - Flags: review?(benjamin)
Attachment #8829208 - Flags: review-
> I *think* this should be Core:: Preferences: Backend but bsmedberg would know for sure.

Actually, autoconfig is correct. It has its own component now.
(Assignee)

Comment 6

a year ago
thanks :mkaply, I will wait for bsmedberg's review
Comment on attachment 8829208 [details] [diff] [review]
add BUG_COMPONENT to extensions/*

Review of attachment 8829208 [details] [diff] [review]:
-----------------------------------------------------------------

Given mkaply's confirmation, r+ from me. I don't think we need to bother Benjamin.

::: extensions/pref/moz.build
@@ +7,5 @@
>  
>  DIRS += ['autoconfig']
> +
> +with Files('**'):
> +    BUG_COMPONENT = ('Core', 'AutoConfig (Mission Control Desktop)')

mkaply confirmed this is the correct component.
Attachment #8829208 - Flags: review?(benjamin)
Attachment #8829208 - Flags: review-
Attachment #8829208 - Flags: review+

Comment 8

a year ago
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bcba677f9c6d
add BUG_COMPONENT to extensions/* files. r=bsmedberg

Comment 9

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/bcba677f9c6d
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.