If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Perma failure in document-fullscreen-enabled.html | Document.fullscreenEnabled - assert_true: top-level document expected true got undefined when aurora moves to beta 52

RESOLVED FIXED in Firefox 52

Status

()

Core
DOM
P1
blocker
RESOLVED FIXED
9 months ago
9 months ago

People

(Reporter: Tomcat, Assigned: jgraham)

Tracking

52 Branch
mozilla54
Points:
---

Firefox Tracking Flags

(firefox52+ fixed, firefox53 fixed, firefox54 fixed)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

9 months ago
found during aurora as beta uplift tests in preparation of next monday merge day and got:


TEST-UNEXPECTED-FAIL | /fullscreen/api/document-fullscreen-enabled.html | Document.fullscreenEnabled - assert_true: top-level document expected true got undefined

https://treeherder.mozilla.org/logviewer.html#?job_id=70620489&repo=try&lineNumber=3316

James i guess its your area
(Reporter)

Comment 1

9 months ago
[Tracking Requested - why for this release]:
possible tree closure reason next merge day
tracking-firefox52: --- → ?
Flags: needinfo?(james)
(Assignee)

Comment 2

9 months ago
Created attachment 8828839 [details] [diff] [review]
1332615.diff

I think this patch should fix it. If you can confirm I can land on inbound and you can uplift as required.
Flags: needinfo?(james) → needinfo?(cbook)
(Reporter)

Comment 3

9 months ago
pushed a try run in https://treeherder.mozilla.org/#/jobs?repo=try&revision=6d43a1238c64ca54b83ab491a1bc58040e7706e0
Flags: needinfo?(cbook)
(Reporter)

Comment 4

9 months ago
yeah seems fixed now \o/ - however we seem to have now https://treeherder.mozilla.org/logviewer.html#?job_id=71110658&repo=try is this also you ? should i file a new bug ?
Flags: needinfo?(james)
Track perma failure on beta for 52.
tracking-firefox52: ? → +
(Reporter)

Updated

9 months ago
Blocks: 1333083
(Assignee)

Comment 6

9 months ago
I don't know what's going on there. I can of course update the metadata to fit the results, but I guess you will need to ask someone who works on web-animations if there's a pref that we can set to make the tests pass.
Flags: needinfo?(james)

Updated

9 months ago
See Also: → bug 1333175
Xidorn confirmed that this is the correct fix. Still need to land it on Aurora at some point.

https://hg.mozilla.org/releases/mozilla-beta/rev/0c43334619e606a5b5ea925c517020bdd49994b7
status-firefox52: --- → fixed
status-firefox53: --- → affected
status-firefox54: --- → affected
Component: web-platform-tests → DOM
Product: Testing → Core
Whiteboard: [checkin-needed-aurora]
Version: Version 3 → 52 Branch

Comment 8

9 months ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ce0fb0e12f0b
Enable unprefixed fullscreen API for fullscreen tests. r=xidorn
Assignee: nobody → james
Priority: -- → P1

Comment 9

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ce0fb0e12f0b
Status: NEW → RESOLVED
Last Resolved: 9 months ago
status-firefox54: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54

Comment 10

9 months ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/afc5a1356407
status-firefox53: affected → fixed
Whiteboard: [checkin-needed-aurora]

Comment 11

9 months ago
54 failures in 749 pushes (0.072 failures/push) were associated with this bug in the last 7 days. 

This is the #31 most frequent failure this week. 

** This failure happened more than 50 times this week! Resolving this bug is a high priority. **

Repository breakdown:
* mozilla-beta: 54

Platform breakdown:
* linux64: 18
* windows8-64: 8
* windows7-32-vm: 8
* osx-10-10: 8
* linux32: 8
* windowsxp: 4

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1332615&startday=2017-01-23&endday=2017-01-29&tree=all
You need to log in before you can comment on or make changes to this bug.