Closed Bug 1332615 Opened 9 years ago Closed 9 years ago

Perma failure in document-fullscreen-enabled.html | Document.fullscreenEnabled - assert_true: top-level document expected true got undefined when aurora moves to beta 52

Categories

(Core :: DOM: Core & HTML, defect, P1)

Product:
Core
Component:
DOM: Core & HTML
Version:
52 Branch
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla54
Tracking Flags:
Tracking Status
firefox52 + fixed
firefox53 --- fixed
firefox54 --- fixed

People

(Reporter: cbook, Assigned: jgraham)

References

(
URL
)

Details

Attachments

(1 file)

1332615.diff
561 bytes, patch
Details | Diff | Splinter Review
found during aurora as beta uplift tests in preparation of next monday merge day and got: TEST-UNEXPECTED-FAIL | /fullscreen/api/document-fullscreen-enabled.html | Document.fullscreenEnabled - assert_true: top-level document expected true got undefined https://treeherder.mozilla.org/logviewer.html#?job_id=70620489&repo=try&lineNumber=3316 James i guess its your area
[Tracking Requested - why for this release]: possible tree closure reason next merge day
tracking-firefox52: --- → ?
Flags: needinfo?(james)
Attached patch 1332615.diff — — Splinter Review
I think this patch should fix it. If you can confirm I can land on inbound and you can uplift as required.
Flags: needinfo?(james) → needinfo?(cbook)
yeah seems fixed now \o/ - however we seem to have now https://treeherder.mozilla.org/logviewer.html#?job_id=71110658&repo=try is this also you ? should i file a new bug ?
Flags: needinfo?(james)
Track perma failure on beta for 52.
tracking-firefox52: ? → +
Blocks: 1333083
I don't know what's going on there. I can of course update the metadata to fit the results, but I guess you will need to ask someone who works on web-animations if there's a pref that we can set to make the tests pass.
Flags: needinfo?(james)
See Also: → 1333175
Xidorn confirmed that this is the correct fix. Still need to land it on Aurora at some point. https://hg.mozilla.org/releases/mozilla-beta/rev/0c43334619e606a5b5ea925c517020bdd49994b7
status-firefox52: --- → fixed
status-firefox53: --- → affected
status-firefox54: --- → affected
Component: web-platform-tests → DOM
Product: Testing → Core
Whiteboard: [checkin-needed-aurora]
Version: Version 3 → 52 Branch
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/ce0fb0e12f0b Enable unprefixed fullscreen API for fullscreen tests. r=xidorn
Assignee: nobody → james
Priority: -- → P1
https://hg.mozilla.org/mozilla-central/rev/ce0fb0e12f0b
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox54: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: