Closed Bug 1333175 Opened 3 years ago Closed 3 years ago

Permafail on merge to beta browser_parsable_css.js | Got error message for html.css: Unknown pseudo-class or pseudo-element ‘fullscreen’. Ruleset ignored due to bad selector. -

Categories

(Firefox :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 54
Tracking Status
firefox52 --- fixed
firefox53 --- fixed
firefox54 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: xidorn)

References

Details

Attachments

(1 file)

The unprefixed fullscreen api is disabled on beta and release, so these tests probably need to be disabled for beta and release: https://hg.mozilla.org/mozilla-central/annotate/3cedab21a7e65e6a1c4c2294ecfb5502575a46e3/modules/libpref/init/all.js#l4766
Given what this test is testing, disabling it isn't the right solution. We should probably revert https://hg.mozilla.org/releases/mozilla-beta/diff/a72b6cfcb2e1/layout/style/html.css instead.
The right solution here should be adding :fullscreen to the whitelist of that test, since we do parse :fullscreen in UA sheet even if unprefixed Fullscreen API is disabled.
Assignee: nobody → xidorn+moz
In an effort to get Beta reopened sooner, I went ahead and pushed this patch there for now. We'll still need to land it on Trunk & Aurora after it gets proper review.

https://hg.mozilla.org/releases/mozilla-beta/rev/5966511a64fde64eb9446a061a3639ab37f26dfa
Comment on attachment 8829685 [details]
Bug 1333175 - Add :fullscreen pseudo-class in ua sheets into whitelist in browser_parsable_css.js.

https://reviewboard.mozilla.org/r/106690/#review107766

Why do we need this patch given

(In reply to Xidorn Quan [:xidorn] (UTC+10) from comment #3)
> The right solution here should be adding :fullscreen to the whitelist of
> that test, since we do parse :fullscreen in UA sheet even if unprefixed
> Fullscreen API is disabled.

If we parse it correctly, why are errors showing up?

And won't this go orange on nightly/aurora because the whitelist entry is "unused"? Should we be adding this exception only if AppPlatform.RELEASE_OR_BETA is not true?
Attachment #8829685 - Flags: review?(gijskruitbosch+bugs)
(In reply to :Gijs from comment #7)
> (In reply to Xidorn Quan [:xidorn] (UTC+10) from comment #3)
> > The right solution here should be adding :fullscreen to the whitelist of
> > that test, since we do parse :fullscreen in UA sheet even if unprefixed
> > Fullscreen API is disabled.
> 
> If we parse it correctly, why are errors showing up?

We parse it correctly as *UA sheet*, but this test parses this sheet as a document stylesheet. It could be parsed correctly if it is parsed with chrome priviledge, but the file is probably not accessible from chrome: protocol, so that doesn't help.

> And won't this go orange on nightly/aurora because the whitelist entry is
> "unused"? Should we be adding this exception only if
> AppPlatform.RELEASE_OR_BETA is not true?

Oh, I only tested that it would prevent the error from showing up, but didn't test the case that it is not used. Yeah, probably we need to add this exception only if AppPlatform.RELEASE_OR_BETA *is* true.
Comment on attachment 8829685 [details]
Bug 1333175 - Add :fullscreen pseudo-class in ua sheets into whitelist in browser_parsable_css.js.

https://reviewboard.mozilla.org/r/106690/#review109808
Attachment #8829685 - Flags: review?(gijskruitbosch+bugs) → review+
Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/265a8f035ade
Add :fullscreen pseudo-class in ua sheets into whitelist in browser_parsable_css.js. r=Gijs
https://hg.mozilla.org/mozilla-central/rev/265a8f035ade
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
Whiteboard: [checkin-needed-aurora]
You need to log in before you can comment on or make changes to this bug.