1333175 - Permafail on merge to beta browser_parsable_css.js | Got error message for html.css: Unknown pseudo-class or pseudo-element ‘fullscreen’. Ruleset ignored due to bad selector. -

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Treeherder Bug Filer]

Filed by: wkocher [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=71247540&repo=mozilla-beta

https://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-beta-linux-pgo/1485186764/mozilla-beta_ubuntu32_vm_test_pgo-mochitest-browser-chrome-6-bm03-tests1-linux32-build1.txt.gz

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

The unprefixed fullscreen api is disabled on beta and release, so these tests probably need to be disabled for beta and release: https://hg.mozilla.org/mozilla-central/annotate/3cedab21a7e65e6a1c4c2294ecfb5502575a46e3/modules/libpref/init/all.js#l4766

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Given what this test is testing, disabling it isn't the right solution. We should probably revert https://hg.mozilla.org/releases/mozilla-beta/diff/a72b6cfcb2e1/layout/style/html.css instead.

Comment 3

[Xidorn Quan [:xidorn] UTC+10]

The right solution here should be adding :fullscreen to the whitelist of that test, since we do parse :fullscreen in UA sheet even if unprefixed Fullscreen API is disabled.

Comment 4

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1333175 - Add :fullscreen pseudo-class in ua sheets into whitelist in browser_parsable_css.js.

Review commit: https://reviewboard.mozilla.org/r/106690/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/106690/

Comment 5

[Intermittent Failures Robot]

28 failures in 127 pushes (0.22 failures/push) were associated with this bug yesterday.  

Repository breakdown:
* mozilla-beta: 28

Platform breakdown:
* linux64: 10
* windows8-64: 4
* windows7-32-vm: 4
* osx-10-10: 4
* linux32: 4
* windowsxp: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1333175&startday=2017-01-23&endday=2017-01-23&tree=all

Comment 6

[Ryan VanderMeulen [:RyanVM]]

In an effort to get Beta reopened sooner, I went ahead and pushed this patch there for now. We'll still need to land it on Trunk & Aurora after it gets proper review.

https://hg.mozilla.org/releases/mozilla-beta/rev/5966511a64fde64eb9446a061a3639ab37f26dfa

Comment 7

[:Gijs (he/him)]

Comment on attachment 8829685 [details]
Bug 1333175 - Add :fullscreen pseudo-class in ua sheets into whitelist in browser_parsable_css.js.

https://reviewboard.mozilla.org/r/106690/#review107766

Why do we need this patch given

(In reply to Xidorn Quan [:xidorn] (UTC+10) from comment #3)
> The right solution here should be adding :fullscreen to the whitelist of
> that test, since we do parse :fullscreen in UA sheet even if unprefixed
> Fullscreen API is disabled.

If we parse it correctly, why are errors showing up?

And won't this go orange on nightly/aurora because the whitelist entry is "unused"? Should we be adding this exception only if AppPlatform.RELEASE_OR_BETA is not true?

Comment 8

[Xidorn Quan [:xidorn] UTC+10]

(In reply to :Gijs from comment #7)
> (In reply to Xidorn Quan [:xidorn] (UTC+10) from comment #3)
> > The right solution here should be adding :fullscreen to the whitelist of
> > that test, since we do parse :fullscreen in UA sheet even if unprefixed
> > Fullscreen API is disabled.
> 
> If we parse it correctly, why are errors showing up?

We parse it correctly as *UA sheet*, but this test parses this sheet as a document stylesheet. It could be parsed correctly if it is parsed with chrome priviledge, but the file is probably not accessible from chrome: protocol, so that doesn't help.

> And won't this go orange on nightly/aurora because the whitelist entry is
> "unused"? Should we be adding this exception only if
> AppPlatform.RELEASE_OR_BETA is not true?

Oh, I only tested that it would prevent the error from showing up, but didn't test the case that it is not used. Yeah, probably we need to add this exception only if AppPlatform.RELEASE_OR_BETA *is* true.

Comment 9

[Intermittent Failures Robot]

28 failures in 749 pushes (0.037 failures/push) were associated with this bug in the last 7 days.  

Repository breakdown:
* mozilla-beta: 28

Platform breakdown:
* linux64: 10
* windows8-64: 4
* windows7-32-vm: 4
* osx-10-10: 4
* linux32: 4
* windowsxp: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1333175&startday=2017-01-23&endday=2017-01-29&tree=all

Comment 10

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8829685 [details]
Bug 1333175 - Add :fullscreen pseudo-class in ua sheets into whitelist in browser_parsable_css.js.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/106690/diff/1-2/

Comment 11

[:Gijs (he/him)]

Comment on attachment 8829685 [details]
Bug 1333175 - Add :fullscreen pseudo-class in ua sheets into whitelist in browser_parsable_css.js.

https://reviewboard.mozilla.org/r/106690/#review109808

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/265a8f035ade
Add :fullscreen pseudo-class in ua sheets into whitelist in browser_parsable_css.js. r=Gijs

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/265a8f035ade

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/6ad72b5a43e1