1332625 - about:support on Android should not link to about:profiles (broken link)

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[Tomer Cohen :tomer]

bug 1179129 introduced a link to about:profiles from about:support. Since about:profiles doesn't exists on the Android port, I see no point in having such link on about:support.

Steps to reproduce:
a. Open about:support on Android.
b. Scroll down to the about:profiles link in the last row of the Application Basics table.
c. Click (or tap).


Actual result:
The address isn't valid error message, since about:profiles isn't available (not listed on about:about as well)

Expected result:
Implement about:profiles or have the link disappear.


This problem affects all versions of Firefox for Android, from release to nightly.

Comment 1

[Tomer Cohen :tomer]

Attachment: Bug 1332625 - about:support on Android should not link to about:profiles (broken link)

Review commit: https://reviewboard.mozilla.org/r/106108/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/106108/

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 8828814 [details]
Bug 1332625 - about:support on Android should not link to about:profiles (broken link)

https://reviewboard.mozilla.org/r/106108/#review108856

Sorry for the delay in getting to this. Looks good. r=Standard8.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8c317b40aa10
about:support on Android should not link to about:profiles (broken link) r=standard8

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/8c317b40aa10

Comment 5

[Julien Cristau [:jcristau]]

Should this be uplifted to aurora and/or beta?

Comment 6

[Tomer Cohen :tomer]

[Tracking Requested - why for this release]: Low risk; Link has been removed using ifdef.

Comment 7

[Tomer Cohen :tomer]

Comment on attachment 8828814 [details]
Bug 1332625 - about:support on Android should not link to about:profiles (broken link)

Approval Request Comment
[Feature/Bug causing the regression]: There is no about:profiles on Android at the moment.
[User impact if declined]: Broken link.
[Is this code covered by automated tests?]:
[Has the fix been verified in Nightly?]: Can be confirmed by myself.
[Needs manual test from QE? If yes, steps to reproduce]: Verification would be great, but not sure if necessary. 
[List of other uplifts needed for the feature/fix]: I am planning to file similar bugs on this page, but there is no dependencies. 
[Is the change risky?]: Probably not.
[Why is the change risky/not risky?]: Link removed using ifdef.
[String changes made/needed]:

Comment 8

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8828814 [details]
Bug 1332625 - about:support on Android should not link to about:profiles (broken link)

Thanks for catching this! Let's uplift to aurora and beta.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/a4ab3c577fe8

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/72b706bd282d