1332759 - Update android builders to rust 1.15.0-beta.4

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Ralph Giles (:rillian)]

New beta toolchain. We should bump the android builders to reduce variance in the Aurora uplift to 1.15 stable. This release is described as a release candidate.

Comment 1

[Ralph Giles (:rillian)]

Attachment: Bug 1332759 - Update android builders to rust 1.15.0-beta.4.

Bump the Android builders to the latest beta release to reduce
the variance when we update Firefox 53 to 1.15.0 stable early
in the Aurora phase.

Android builds were moved to 1.15 early to address a code generation
issue with devices without neon.

Work around an issue with tarball naming in the cargo packages.

Review commit: https://reviewboard.mozilla.org/r/106204/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/106204/

Comment 2

[Michael Shal [:mshal]]

Comment on attachment 8828989 [details]
Bug 1332759 - Update android builders to rust 1.15.0-beta.4.

https://reviewboard.mozilla.org/r/106204/#review107660

::: taskcluster/docker/rust-build/repack_rust.py:61
(Diff revision 1)
>      '''Run a package's installer script against the given target directory.'''
>      print(' Unpacking %s...' % filename)
>      subprocess.check_call(['tar', 'xf', filename])
>      basename = filename.split('.tar')[0]
> +    # Work around bad tarball naming in 1.15 cargo packages.
> +    basename = basename.replace('cargo-beta', 'cargo-nightly')

Why is this stuff needed? I don't see how it related to bumping the rustc revision for android.

Comment 3

[Ralph Giles (:rillian)]

Comment on attachment 8828989 [details]
Bug 1332759 - Update android builders to rust 1.15.0-beta.4.

https://reviewboard.mozilla.org/r/106204/#review107676

::: taskcluster/docker/rust-build/repack_rust.py:61
(Diff revision 1)
>      '''Run a package's installer script against the given target directory.'''
>      print(' Unpacking %s...' % filename)
>      subprocess.check_call(['tar', 'xf', filename])
>      basename = filename.split('.tar')[0]
> +    # Work around bad tarball naming in 1.15 cargo packages.
> +    basename = basename.replace('cargo-beta', 'cargo-nightly')

These are the script changes which generate the new tooltool objects the manifest changes point to. I've had questions in the past about where the artifacts come from, so I wanted to keep the in-tree scripts up to date.

If you don't want it I can leave it out.

Comment 4

[Michael Shal [:mshal]]

(In reply to Ralph Giles (:rillian) | needinfo me from comment #3)
> These are the script changes which generate the new tooltool objects the
> manifest changes point to. I've had questions in the past about where the
> artifacts come from, so I wanted to keep the in-tree scripts up to date.
> 
> If you don't want it I can leave it out.

I agree keeping them up-to-date is important. I was more concerned that the replace()s would have to be updated each time a new cargo version was updated, but based on our IRC conversation it sounds like this could go away soon anyway. I guess if it becomes a problem we can convert it to a regex or something.

Comment 5

[Ralph Giles (:rillian)]

I see. I put the 0.16 substitution in a future-proofing, but we could make it more general if it isn't resolved in the next release cycle. Thanks for the review!

Comment 6

[Ralph Giles (:rillian)]

Comment on attachment 8828989 [details]
Bug 1332759 - Update android builders to rust 1.15.0-beta.4.

https://reviewboard.mozilla.org/r/106204/#review107680

propagating r=mshal from bugzilla.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/18ba44329cd0
Update android builders to rust 1.15.0-beta.4. r=rillian

Comment 8

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/18ba44329cd0

Comment 9

[Ralph Giles (:rillian)]

Comment on attachment 8828989 [details]
Bug 1332759 - Update android builders to rust 1.15.0-beta.4.

I'd hoped to get this in before 53 when to Aurora, but there wasn't time. Nominating for uplift now so we get testing earlier in the cycle.

Approval Request Comment

[Feature/Bug causing the regression]: Bug 1323773 (mp4 playback)

[User impact if declined]: Minor increased risk to fennec users.

[Is this code covered by automated tests?]: Yes.

[Has the fix been verified in Nightly?]: Not yet.

[Needs manual test from QE? If yes, steps to reproduce]: No manual testing is necessary.

[List of other uplifts needed for the feature/fix]: Bug 1333448 will provide the final update in 10 days or so.

[Is the change risky?]: No.
[Why is the change risky/not risky?]: This update fixes some rust toolchain bugs which do not affect our code. This patch moves us from the early beta.2 release to the beta.4 release candidate. This reduces variance with what we intend to release with (1.15.0 stable, not yet available) so if there are unexpected problems we're more likely to find them early in the aurora cycle.
 
[String changes made/needed]: None

Comment 10

[Ralph Giles (:rillian)]

I've verified the new Nightly Android builds.

Also, I wanted to note a 1.15.0-beta.5 has been released. The changes from beta.4 are build fixes for BSD platforms, so we don't need to update our android builders.

Comment 11

[Liz Henry (:lizzard) (relman/hg->git project)]

Ralph, do you still want to uplift this to 53? Or are you saying in comment 10 that we don't need it?

Comment 12

[Ralph Giles (:rillian)]

Hi Liz. I would still like to uplift this to 53. Comment 10 was about the patch _not_ being obsoleted by more recent upstream activity.

Comment 13

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8828989 [details]
Bug 1332759 - Update android builders to rust 1.15.0-beta.4.

Approving this assuming this was a plan for Fennec 53 all along. Aurora53+

Comment 14

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

FYI Liz, Gerry.

Comment 15

[Ralph Giles (:rillian)]

Thanks, Ritu!

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/dec18ea1f117