1333448 - update android builders to rust 1.15.1 stable for firefox 53

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Ralph Giles (:rillian)]

Rust 1.15.0 stable is to be released February 2. At that point we'll want to uplift a bump to that version for android builds of Firefox 53, on the Aurora branch, to meet our goal of shipping builds from stable rust.

Few changes are expected on top of 1.15.0-beta.4 from bug 1332759.

Comment 1

[Ralph Giles (:rillian)]

Attachment: Bug 1333448 - Update Android builders to rust 1.15.1.

Bump our Android config for official builds to use the stable
1.15 release so we ship with a stable toolchain. Backport of
the relevant portions of bug 1338311 from Firefox 54.

Per bug 1323773, we shipped Firefox 53 with rust 1.15 ahead
of schedule on Android to pick up the fix to support non-neon
armv7 devices.

Review commit: https://reviewboard.mozilla.org/r/112440/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/112440/

Comment 2

[Ralph Giles (:rillian)]

Comment on attachment 8837270 [details]
Bug 1333448 - Update Android builders to rust 1.15.1.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1323773
[User impact if declined]: Official fennec release will be built with a beta rust toolchain, breaking one of our stability goals.
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: Change is not risky.
[Why is the change risky/not risky?]: We've validated the stable toolchain release on nightly. By using the official release instead of a beta we reduce risk by following more broadly-tested code.
[String changes made/needed]: None

Comment 3

[Michael Shal [:mshal]]

Comment on attachment 8837270 [details]
Bug 1333448 - Update Android builders to rust 1.15.1.

https://reviewboard.mozilla.org/r/112440/#review114572

Comment 4

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8837270 [details]
Bug 1333448 - Update Android builders to rust 1.15.1.

Update to rust stable version.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/5a45005087d21b83fc59c34a5b14ea0c9356c51e