Closed Bug 1332763 Opened 7 years ago Closed 7 years ago

pressing "Ship It" when there's no review request doesn't mark the patch as review+

Categories

(MozReview Graveyard :: General, defect)

Product:
MozReview Graveyard
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED INVALID

People

(Reporter: dbaron, Unassigned)

References

Details

+++ This bug was initially created as a clone of Bug #1332346 +++

In bug 1326406 I reviewed a patch with no review request and pressed the "Ship It" button.  Doing so gave me a confirmation dialog, and then just made a "Ship it" comment in the bug without actually marking the patch review+ (bug 1326406 comment 7).  The state in MozReview itself also indicated that the patch had not been reviewed.

I would have expected pressing the "Ship It" button (which I don't use much) would have marked the patch as review+.
The Ship It button is normally disabled, isn't it?  We probably didn't update the behaviour when the r+/r- stuff landed since it shouldn't be visible.  I take it you've enabled it in your browser with a CSS hack or something like that?
Oh, I guess I do have some user CSS to make it show up from sometime in the past when that was useful.
invalid as per comment 2.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.