1333061 - Autophone - create_worker should raise exceptions on failure

Status: RESOLVED FIXED

(Testing Graveyard :: Autophone, defect)

Description

[Bob Clary [:bc] (inactive)]

Over the weekend after deploying the most recent changes, we ran into a startup hang due to the failure to create a worker.

2017-01-22 02:47:03,697|955|MainThread|console|INFO|Initializing device name=nexus-6p-5, serialno=84B7N15A28009689
2017-01-22 02:49:19,054|955|MainThread|console|ERROR|Unable to create worker for device nexus-6p-5 due to Can not run command ls -a /sdcard/tests/autophone/ as root!.
2017-01-22 02:49:19,126|955|MainThread|console|INFO|Worker nexus-6p-5 failed to register
2017-01-22 02:49:19,126|955|MainThread|console|ERROR|Unable to initialize device nexus-6p-5 due to 'S1S2Test' object has no attribute 'run_if_changed'.

Callers of create_worker currently expect that it will return a reference to the newly created PhoneWorker but create_worker does not if there are no tests for the worker:
https://github.com/mozilla/autophone/blob/master/autophone.py#L688

In addition, if the creation of the tests for the worker fail due an exception, 

https://github.com/mozilla/autophone/blob/master/autophone.py#L683

we currently just purge the worker but fall through and attempt to create a PhoneWorker for a device which is not responding.

Comment 1

[Bob Clary [:bc] (inactive)]

Attachment: bug-1333061-create_worker-v1.patch

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8829432 [details] [diff] [review]
bug-1333061-create_worker-v1.patch

Review of attachment 8829432 [details] [diff] [review]:
-----------------------------------------------------------------

great

Comment 3

[Bob Clary [:bc] (inactive)]

https://github.com/mozilla/autophone/commit/68b2a9166f19c144da981122bd7669c07f66bca5

deployed 2017-01-24 ~10:40