1333070 - Crash in OOM | small (when trying to upload a large video file to youtube)

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect, P1)

Description

[Ciprian Georgiu [:ciprian_georgiu], Release Desktop QA]

This bug was filed from the Socorro interface and is 
report bp-a44f30d8-f964-4285-8018-f758c2170123.
=============================================================

Comment 1

[Ciprian Georgiu [:ciprian_georgiu], Release Desktop QA]

[Note]:
- this is a follow-up found in bug 1324875

[Affected versions]:
- latest Aurora 52.0a2 
- 51.0 (20170118123726)
- 50.1.0 (20161208153507)

[Affected platforms]:
- all Ubuntu LTS x86

[Steps to reproduce]:
1. Start Firefox and log into your YouTube account.
3. Upload a large video file. (I used a 5 Gb file to reproduce this issue)

[Expected result]:
- Firefox is uploading the file successfully.

[Actual result]:
- Firefox crashes while uploading the file and it usually happens after 50%.

[Regression range]:
- I was not able to reproduce this crash on Firefox 39.0 (20150630154324). However, I think it would take a lot of time to find a regression range, since the uploading is very slow on my machine.  

[Additional notes]:
- latest Nightly 53.0a1 seems to be unaffected
- reproducible only with 32-bit architecture

Comment 2

[Andrew Overholt [:overholt]]

Catalin, can you take a look?

Comment 3

[Ryan VanderMeulen [:RyanVM]]

The symptoms sound a lot like bug 1332587 (which conveniently is only fixed in 53+). We're trying to get that and bug 1332602 uplifted to 52 now (and should keep them on the radar in the event of a 51 dot release as well).

Comment 4

[Ryan VanderMeulen [:RyanVM]]

We've uplifted the fixes referenced in comment 3 to Beta for 52b3. Can you please re-test this on a CI build or once b3 gets created later this week? I'm also marking this as fix-optional for 51 since I think this is edge-case enough to not be a priority for a dot-release ride-along.

Comment 5

[Ciprian Georgiu [:ciprian_georgiu], Release Desktop QA]

Sorry for my late reply.
I've re-tested this issue and it's still reproducible on 52.0b3, (Ubuntu 16.04 LTS x86) following the same str from comment 0.
- https://crash-stats.mozilla.com/report/index/48f364af-e261-4531-873e-02d6a2170206

Please let me know if I can help you with more info.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Looks like OOMs in the JS engine.

Comment 7

[Yorgos]

https://crash-stats.mozilla.com/report/index/bd64a14b-10dd-45fa-a355-5770f2170228

Comment 8

[Julien Cristau [:jcristau]]

Mass wontfix for bugs affecting firefox 52.

Comment 9

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

This is an assigned P1 bug without activity in two weeks. 

If you intend to continue working on this bug for the current release/iteration/sprint, remove the 'stale-bug' keyword.

Otherwise we'll reset the priority of the bug back to '--' on Monday, August 28th.

Comment 10

[Hsin-Yi Tsai (away for a while) [:hsinyi]]

Ciprian, Comment 0 said it's unaffected in 53 and 54, and I am wondering the status of the latest version. Could you please confirm if this is valid in the latest nightly 57 ? Shall we close this?

Comment 11

[Andrew Overholt [:overholt]]

Commence questions with obvious answers: Are these crashes because we're attempting to put an entire video into memory and it's bigger than the available RAM (+swap?)? Is streaming the upload possible?

Comment 12

[Andrea Marchesini [:baku]]

YouTube uses FileReader to take a portion of the uploaded video in memory: some operations (maybe the thumbnails?) run on the browser during the upload. For the rest, the upload doesn't require the keeping of the file in memory.
Btw, with IPCBlob, any operation should take less memory in 57 compared with previous releases. I suspect this bug is already fixed in nightly.

Comment 13

[Ciprian Georgiu [:ciprian_georgiu], Release Desktop QA]

(In reply to Hsin-Yi Tsai [:hsinyi] from comment #10)
> Ciprian, Comment 0 said it's unaffected in 53 and 54, and I am wondering the
> status of the latest version. Could you please confirm if this is valid in
> the latest nightly 57 ? Shall we close this?

I can't reproduce this on latest Nightly 57.0a1 (2017-09-20) with Ubuntu 16.04 x86. Feel free to close this bug.

Comment 14

[Hsin-Yi Tsai (away for a while) [:hsinyi]]

Per comment 12 and comment 13, close this as fixed.