Remove references to SPS in the code

RESOLVED FIXED

Status

()

defect
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: njn, Assigned: njn)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(8 attachments)

Assignee

Description

2 years ago
There are lots of SPS references still in the codebase. Let's change them to "the Gecko Profiler".
Assignee

Comment 1

2 years ago
glandium, I'm requesting co-review from you because this touches build system
files.
Attachment #8829717 - Flags: review?(mstange)
Attachment #8829717 - Flags: review?(mh+mozilla)
Assignee

Updated

2 years ago
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
Assignee

Comment 4

2 years ago
They are all in comments.
Attachment #8829725 - Flags: review?(mstange)
Assignee

Comment 6

2 years ago
Shu, apologies for the monumentally boring patch.
Attachment #8829730 - Flags: review?(shu)
Assignee

Comment 7

2 years ago
After these patches, the only notable use of SPS left in the codebase is for the constants defined in tools/profiler/core/PlatformMacros.h, which I'll do in a separate bug.
Attachment #8829717 - Flags: review?(mh+mozilla) → review+
Attachment #8829717 - Flags: review?(mstange) → review+
Attachment #8829718 - Flags: review?(mstange) → review+
Attachment #8829724 - Flags: review?(mstange) → review+
Attachment #8829725 - Flags: review?(mstange) → review+
Attachment #8829726 - Flags: review?(mstange) → review+
(In reply to Nicholas Nethercote [:njn] from comment #7)
> After these patches, the only notable use of SPS left in the codebase is for
> the constants defined in tools/profiler/core/PlatformMacros.h, which I'll do
> in a separate bug.

I also see sps_profiler_define / sps_profiler in toolkit/moz.configure.
And the "--spsProfile*" command line flags in talos.py; changing those would also require updating the try syntax builder and some documentation on MDN.
Assignee

Updated

2 years ago
Keywords: leave-open
Attachment #8830055 - Flags: review?(mh+mozilla) → review+
Assignee

Comment 12

2 years ago
> I also see sps_profiler_define / sps_profiler in toolkit/moz.configure.

Thanks. I changed these in part 7, and I found a few more similar ones, which are in part 8.

> And the "--spsProfile*" command line flags in talos.py; changing those would
> also require updating the try syntax builder and some documentation on MDN.

Looks like we have three:
* --spsProfile
* --spsProfileInterval
* --spsProfileEntries

I will leave these unchanged for now because I don't want to coordinate updates to multiple repos.
Attachment #8830117 - Flags: review?(mstange) → review+
Comment on attachment 8829730 [details] [diff] [review]
(part 6) - Remove SPS references in js/

Review of attachment 8829730 [details] [diff] [review]:
-----------------------------------------------------------------

I confess I only skimmed through the renamings, but it looks perfectly reasonable. Thanks for the detailed commit message.
Attachment #8829730 - Flags: review?(shu) → review+
Assignee

Updated

2 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Keywords: leave-open
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.