Remove references to SPS in the code

RESOLVED FIXED

Status

()

Core
Gecko Profiler
RESOLVED FIXED
3 months ago
2 months ago

People

(Reporter: njn, Assigned: njn)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(8 attachments)

(Assignee)

Description

3 months ago
There are lots of SPS references still in the codebase. Let's change them to "the Gecko Profiler".
(Assignee)

Comment 1

3 months ago
Created attachment 8829717 [details] [diff] [review]
(part 1) - Rename MOZ_ENABLE_PROFILER_SPS as MOZ_GECKO_PROFILER

glandium, I'm requesting co-review from you because this touches build system
files.
Attachment #8829717 - Flags: review?(mstange)
Attachment #8829717 - Flags: review?(mh+mozilla)
(Assignee)

Updated

3 months ago
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
(Assignee)

Comment 2

3 months ago
Created attachment 8829718 [details] [diff] [review]
(part 2) - Change "SPS:" mentions in logging code
Attachment #8829718 - Flags: review?(mstange)
(Assignee)

Comment 3

3 months ago
Created attachment 8829724 [details] [diff] [review]
(part 3) - Remove SPS mentions in tools/profiler
Attachment #8829724 - Flags: review?(mstange)
(Assignee)

Comment 4

3 months ago
Created attachment 8829725 [details] [diff] [review]
(part 4) - Remove SPS references in testing/talos/

They are all in comments.
Attachment #8829725 - Flags: review?(mstange)
(Assignee)

Comment 5

3 months ago
Created attachment 8829726 [details] [diff] [review]
(part 5) - Remove SPS references in devtools/ and dom/
Attachment #8829726 - Flags: review?(mstange)
(Assignee)

Comment 6

3 months ago
Created attachment 8829730 [details] [diff] [review]
(part 6) - Remove SPS references in js/

Shu, apologies for the monumentally boring patch.
Attachment #8829730 - Flags: review?(shu)
(Assignee)

Comment 7

3 months ago
After these patches, the only notable use of SPS left in the codebase is for the constants defined in tools/profiler/core/PlatformMacros.h, which I'll do in a separate bug.
Blocks: 1328363
Attachment #8829717 - Flags: review?(mh+mozilla) → review+
Attachment #8829717 - Flags: review?(mstange) → review+
Attachment #8829718 - Flags: review?(mstange) → review+
Attachment #8829724 - Flags: review?(mstange) → review+
Attachment #8829725 - Flags: review?(mstange) → review+
Attachment #8829726 - Flags: review?(mstange) → review+
(In reply to Nicholas Nethercote [:njn] from comment #7)
> After these patches, the only notable use of SPS left in the codebase is for
> the constants defined in tools/profiler/core/PlatformMacros.h, which I'll do
> in a separate bug.

I also see sps_profiler_define / sps_profiler in toolkit/moz.configure.
And the "--spsProfile*" command line flags in talos.py; changing those would also require updating the try syntax builder and some documentation on MDN.
(Assignee)

Comment 9

3 months ago
Created attachment 8830055 [details] [diff] [review]
(part 7) - Remove SPS references in tookit/moz.configure
Attachment #8830055 - Flags: review?(mh+mozilla)
(Assignee)

Comment 10

3 months ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/8a1b2dbf2f143a69865b59632bbf6c303b929d50
Bug 1333296 (part 1) - Rename MOZ_ENABLE_PROFILER_SPS as MOZ_GECKO_PROFILER. r=mstange,glandium.

https://hg.mozilla.org/integration/mozilla-inbound/rev/205707751e6e5b68b72dfa6fafb4bf7ab8e2f49b
Bug 1333296 (part 2) - Change "SPS:" mentions in logging code. r=mstange.

https://hg.mozilla.org/integration/mozilla-inbound/rev/cc24014e56e979110b15952a2da6b11233a1384f
Bug 1333296 (part 3) - Remove SPS mentions in tools/profiler. r=mstange.

https://hg.mozilla.org/integration/mozilla-inbound/rev/c785789f0dd92065a81418b983a28171a7cfe171
Bug 1333296 (part 4) - Remove SPS references in testing/talos/. r=mstange.

https://hg.mozilla.org/integration/mozilla-inbound/rev/a085cb9e5f0ceb5ae09b91ab1bc11706bea0c96e
Bug 1333296 (part 5) - Remove SPS references in devtools/ and dom/. r=mstange.
(Assignee)

Updated

3 months ago
Keywords: leave-open
Attachment #8830055 - Flags: review?(mh+mozilla) → review+
(Assignee)

Comment 11

3 months ago
Created attachment 8830117 [details] [diff] [review]
(part 8) - Remove more SPS references
Attachment #8830117 - Flags: review?(mstange)
(Assignee)

Comment 12

3 months ago
> I also see sps_profiler_define / sps_profiler in toolkit/moz.configure.

Thanks. I changed these in part 7, and I found a few more similar ones, which are in part 8.

> And the "--spsProfile*" command line flags in talos.py; changing those would
> also require updating the try syntax builder and some documentation on MDN.

Looks like we have three:
* --spsProfile
* --spsProfileInterval
* --spsProfileEntries

I will leave these unchanged for now because I don't want to coordinate updates to multiple repos.

Comment 13

3 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/8a1b2dbf2f14
https://hg.mozilla.org/mozilla-central/rev/205707751e6e
https://hg.mozilla.org/mozilla-central/rev/cc24014e56e9
https://hg.mozilla.org/mozilla-central/rev/c785789f0dd9
https://hg.mozilla.org/mozilla-central/rev/a085cb9e5f0c
Attachment #8830117 - Flags: review?(mstange) → review+

Comment 14

3 months ago
Comment on attachment 8829730 [details] [diff] [review]
(part 6) - Remove SPS references in js/

Review of attachment 8829730 [details] [diff] [review]:
-----------------------------------------------------------------

I confess I only skimmed through the renamings, but it looks perfectly reasonable. Thanks for the detailed commit message.
Attachment #8829730 - Flags: review?(shu) → review+
(Assignee)

Comment 15

3 months ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/09841bae5cafa6700994f363621e58e2e8d6c355
Bug 1333296 (part 6) - Remove SPS references in js/. r=shu.

https://hg.mozilla.org/integration/mozilla-inbound/rev/9a606c3f83b22face35bcd70b4536066ff75eb3b
Bug 1333296 (part 7) - Remove SPS references in tookit/moz.configure. r=glandium.

https://hg.mozilla.org/integration/mozilla-inbound/rev/4d2b14111392bd1f1e2a11c9d002793b2e9f50d8
Bug 1333296 (part 8) - Remove more SPS references. r=mstange.

Comment 16

3 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/09841bae5caf
https://hg.mozilla.org/mozilla-central/rev/9a606c3f83b2
https://hg.mozilla.org/mozilla-central/rev/4d2b14111392
(Assignee)

Updated

3 months ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 months ago
Keywords: leave-open
Resolution: --- → FIXED
Depends on: 1340267
You need to log in before you can comment on or make changes to this bug.