Closed
Bug 1333296
Opened 8 years ago
Closed 8 years ago
Remove references to SPS in the code
Categories
(Core :: Gecko Profiler, defect)
Core
Gecko Profiler
Tracking
()
RESOLVED
FIXED
People
(Reporter: n.nethercote, Assigned: n.nethercote)
References
Details
Attachments
(8 files)
57.08 KB,
patch
|
mstange
:
review+
glandium
:
review+
|
Details | Diff | Splinter Review |
4.55 KB,
patch
|
mstange
:
review+
|
Details | Diff | Splinter Review |
11.58 KB,
patch
|
mstange
:
review+
|
Details | Diff | Splinter Review |
10.09 KB,
patch
|
mstange
:
review+
|
Details | Diff | Splinter Review |
4.33 KB,
patch
|
mstange
:
review+
|
Details | Diff | Splinter Review |
153.02 KB,
patch
|
shu
:
review+
|
Details | Diff | Splinter Review |
1.46 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
16.15 KB,
patch
|
mstange
:
review+
|
Details | Diff | Splinter Review |
There are lots of SPS references still in the codebase. Let's change them to "the Gecko Profiler".
![]() |
Assignee | |
Comment 1•8 years ago
|
||
glandium, I'm requesting co-review from you because this touches build system
files.
Attachment #8829717 -
Flags: review?(mstange)
Attachment #8829717 -
Flags: review?(mh+mozilla)
![]() |
Assignee | |
Updated•8 years ago
|
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
![]() |
Assignee | |
Comment 2•8 years ago
|
||
Attachment #8829718 -
Flags: review?(mstange)
![]() |
Assignee | |
Comment 3•8 years ago
|
||
Attachment #8829724 -
Flags: review?(mstange)
![]() |
Assignee | |
Comment 4•8 years ago
|
||
They are all in comments.
Attachment #8829725 -
Flags: review?(mstange)
![]() |
Assignee | |
Comment 5•8 years ago
|
||
Attachment #8829726 -
Flags: review?(mstange)
![]() |
Assignee | |
Comment 6•8 years ago
|
||
Shu, apologies for the monumentally boring patch.
Attachment #8829730 -
Flags: review?(shu)
![]() |
Assignee | |
Comment 7•8 years ago
|
||
After these patches, the only notable use of SPS left in the codebase is for the constants defined in tools/profiler/core/PlatformMacros.h, which I'll do in a separate bug.
Blocks: profiler-cleanup
Updated•8 years ago
|
Attachment #8829717 -
Flags: review?(mh+mozilla) → review+
Updated•8 years ago
|
Attachment #8829717 -
Flags: review?(mstange) → review+
Updated•8 years ago
|
Attachment #8829718 -
Flags: review?(mstange) → review+
Updated•8 years ago
|
Attachment #8829724 -
Flags: review?(mstange) → review+
Updated•8 years ago
|
Attachment #8829725 -
Flags: review?(mstange) → review+
Updated•8 years ago
|
Attachment #8829726 -
Flags: review?(mstange) → review+
Comment 8•8 years ago
|
||
(In reply to Nicholas Nethercote [:njn] from comment #7)
> After these patches, the only notable use of SPS left in the codebase is for
> the constants defined in tools/profiler/core/PlatformMacros.h, which I'll do
> in a separate bug.
I also see sps_profiler_define / sps_profiler in toolkit/moz.configure.
And the "--spsProfile*" command line flags in talos.py; changing those would also require updating the try syntax builder and some documentation on MDN.
![]() |
Assignee | |
Comment 9•8 years ago
|
||
Attachment #8830055 -
Flags: review?(mh+mozilla)
![]() |
Assignee | |
Comment 10•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/8a1b2dbf2f143a69865b59632bbf6c303b929d50
Bug 1333296 (part 1) - Rename MOZ_ENABLE_PROFILER_SPS as MOZ_GECKO_PROFILER. r=mstange,glandium.
https://hg.mozilla.org/integration/mozilla-inbound/rev/205707751e6e5b68b72dfa6fafb4bf7ab8e2f49b
Bug 1333296 (part 2) - Change "SPS:" mentions in logging code. r=mstange.
https://hg.mozilla.org/integration/mozilla-inbound/rev/cc24014e56e979110b15952a2da6b11233a1384f
Bug 1333296 (part 3) - Remove SPS mentions in tools/profiler. r=mstange.
https://hg.mozilla.org/integration/mozilla-inbound/rev/c785789f0dd92065a81418b983a28171a7cfe171
Bug 1333296 (part 4) - Remove SPS references in testing/talos/. r=mstange.
https://hg.mozilla.org/integration/mozilla-inbound/rev/a085cb9e5f0ceb5ae09b91ab1bc11706bea0c96e
Bug 1333296 (part 5) - Remove SPS references in devtools/ and dom/. r=mstange.
![]() |
Assignee | |
Updated•8 years ago
|
Keywords: leave-open
Updated•8 years ago
|
Attachment #8830055 -
Flags: review?(mh+mozilla) → review+
![]() |
Assignee | |
Comment 11•8 years ago
|
||
Attachment #8830117 -
Flags: review?(mstange)
![]() |
Assignee | |
Comment 12•8 years ago
|
||
> I also see sps_profiler_define / sps_profiler in toolkit/moz.configure.
Thanks. I changed these in part 7, and I found a few more similar ones, which are in part 8.
> And the "--spsProfile*" command line flags in talos.py; changing those would
> also require updating the try syntax builder and some documentation on MDN.
Looks like we have three:
* --spsProfile
* --spsProfileInterval
* --spsProfileEntries
I will leave these unchanged for now because I don't want to coordinate updates to multiple repos.
Comment 13•8 years ago
|
||
bugherder |
Updated•8 years ago
|
Attachment #8830117 -
Flags: review?(mstange) → review+
Comment 14•8 years ago
|
||
Comment on attachment 8829730 [details] [diff] [review]
(part 6) - Remove SPS references in js/
Review of attachment 8829730 [details] [diff] [review]:
-----------------------------------------------------------------
I confess I only skimmed through the renamings, but it looks perfectly reasonable. Thanks for the detailed commit message.
Attachment #8829730 -
Flags: review?(shu) → review+
![]() |
Assignee | |
Comment 15•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/09841bae5cafa6700994f363621e58e2e8d6c355
Bug 1333296 (part 6) - Remove SPS references in js/. r=shu.
https://hg.mozilla.org/integration/mozilla-inbound/rev/9a606c3f83b22face35bcd70b4536066ff75eb3b
Bug 1333296 (part 7) - Remove SPS references in tookit/moz.configure. r=glandium.
https://hg.mozilla.org/integration/mozilla-inbound/rev/4d2b14111392bd1f1e2a11c9d002793b2e9f50d8
Bug 1333296 (part 8) - Remove more SPS references. r=mstange.
Comment 16•8 years ago
|
||
bugherder |
![]() |
Assignee | |
Updated•8 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•