Closed Bug 1340267 Opened 3 years ago Closed 3 years ago

Talos profiling support is broken

Categories

(Testing :: Talos, defect)

defect
Not set

Tracking

(firefox54 fixed)

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: mconley, Assigned: mconley)

References

Details

Attachments

(3 files)

I can't get profiles for Talos tests locally. It looks like a number of our Talos scripts were updated to expect gecko_profiler_* parameters, but not all of them.
Oh no
Sorry! Are these scripts not stored in mozilla-central?
Yessir, under the testing/talos directory.

I have a patch coming up. Brace yourselves.
Comment on attachment 8838227 [details]
Bug 1340267 - Rename SPS to Gecko where possible within Talos.

https://reviewboard.mozilla.org/r/113170/#review114664

keep in mind all the addons will need new signing:
https://wiki.mozilla.org/EngineeringProductivity/HowTo/SignExtensions
Attachment #8838227 - Flags: review?(jmaher) → review+
Comment on attachment 8838228 [details]
Bug 1340267 - Rename SPS to Gecko for Talos tests run from mozharness.

https://reviewboard.mozilla.org/r/113172/#review114668

we still need to fix the trychooser page, please ni me for figuring that out unless you know off the top of your head. Also wiki page needs some attention:
https://wiki.mozilla.org/Buildbot/Talos/Profiling

I can help out tomorrow as needed!
Attachment #8838228 - Flags: review?(jmaher) → review+
Apologies again for the poor job I did on this. Thank you for cleaning up my mess, mconley.

One question: my changes landed 3 weeks ago but the problems have only just been noticed. Is this rarely-used functionality?
(In reply to Nicholas Nethercote [:njn] from comment #8)
> Apologies again for the poor job I did on this. Thank you for cleaning up my
> mess, mconley.

No worries at all. :)

> 
> One question: my changes landed 3 weeks ago but the problems have only just
> been noticed. Is this rarely-used functionality?

Yeah, I think this code is only ever really kicked whenever there's a Talos regression and somebody needs to investigate deeply. Outside of that... I don't think it's often used.
Comment on attachment 8838227 [details]
Bug 1340267 - Rename SPS to Gecko where possible within Talos.

https://reviewboard.mozilla.org/r/113170/#review114708

Thank you!
Attachment #8838227 - Flags: review?(mstange) → review+
Comment on attachment 8838640 [details]
Bug 1340267 - Bump versions and sign affected talos add-ons.

https://reviewboard.mozilla.org/r/113478/#review115074
Attachment #8838640 - Flags: review?(jmaher) → review+
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/244d26586bd6
Rename SPS to Gecko where possible within Talos. r=jmaher,mstange
https://hg.mozilla.org/integration/autoland/rev/126e1d2f0833
Rename SPS to Gecko for Talos tests run from mozharness. r=jmaher
https://hg.mozilla.org/integration/autoland/rev/c4b31df6a118
Bump versions and sign affected talos add-ons. r=jmaher
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/94bf18f8f5be
Fixing linting failures in gecko_profile.py. r=me
There are a few remaining instances of --spsProfile in taskcluster/taskgraph: http://searchfox.org/mozilla-central/search?q=spsprofile&path=taskcluster
Do these need to be changed as well?
Flags: needinfo?(mconley)
See Also: → 1354964
(In reply to Markus Stange [:mstange] from comment #19)
> There are a few remaining instances of --spsProfile in
> taskcluster/taskgraph:
> http://searchfox.org/mozilla-central/search?q=spsprofile&path=taskcluster
> Do these need to be changed as well?

I ... have no idea what those do, honestly. But I presume they need to be updated, yes. I'll file a new bug for that.
Flags: needinfo?(mconley)
we would need to change these as well, :igoldan, is this something you could do this week?
Flags: needinfo?(ionut.goldan)
:jmaher I believe so. I'm starting to look over this one.
Flags: needinfo?(ionut.goldan)
You need to log in before you can comment on or make changes to this bug.