1333511 - Port bug 1277968 - Use the executable for non-plugin child processes on Linux

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[aleth [:aleth]]

+++ This bug was initially created as a clone of Bug #1277968 +++

This is a followup for bug 1114647 — using the "firefox" executable to run content processes (instead of the confusingly named plugin-container) can't work on Linux currently because of how the sandbox code makes various things depend on each other, combined with firefox (with libmozsandbox statically linked into it, on desktop) not being able to link directly against libxul the way plugin-container can.

See bug 1268733 comment #9 for more context and an idea about how to deal with this: replace the symbol dependencies between libmozsandbox and libxul by passing appropriate pointers as part of XREChildData, and then linkage won't matter (and, as a side effect, the weak symbol hacks can go away).

Comment 1

[aleth [:aleth]]

Try push to check the naive port works fine with c-c not setting MOZ_SANDBOX, and the paths to the plugin-container: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=e684380bc4cb4c05a449d56a32044b39b8441a80

Comment 2

[aleth [:aleth]]

(In reply to aleth [:aleth] from comment #1)
> Try push to check the naive port works fine with c-c not setting
> MOZ_SANDBOX, and the paths to the plugin-container:

sorry, I meant MOZ_CONTENT_SANDBOX of course, iirc that's not set for TB.

Comment 3

[aleth [:aleth]]

Attachment: Port bug 1277968: Use the executable for non-plugin child processes on Linux

Comment 4

[Jorg K (CEST = GMT+2)]

Comment on attachment 8830032 [details] [diff] [review]
Port bug 1277968: Use the executable for non-plugin child processes on Linux

So we make the "almost the same" "even more almost the same" ;-)

Thanks!

Comment 5

[aleth [:aleth]]

Try looks OK (compared with c-c).

Comment 6

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/60e4648f97111ce2d5cc2fd46b49c00fdfeda06a
Bug 1333511 - Port bug 1277968: Use the executable for non-plugin child processes on Linux. r=jorgk,clokep

Comment 7

[aleth [:aleth]]

Comment on attachment 8830032 [details] [diff] [review]
Port bug 1277968: Use the executable for non-plugin child processes on Linux

[Approval Request Comment]
Regression caused by (bug #): Blocking bug landed on 53
User impact if declined: possible Linux child process issues
Testing completed (on c-c, etc.): green(ish) try
Risk to taking this patch (and alternatives if risky): low

Comment 8

[Jorg K (CEST = GMT+2)]

Aurora (TB 53):
https://hg.mozilla.org/releases/comm-aurora/rev/bf1551348f1a8552999a3accccbb27eda958ccb7