1333590 - Remove legacy messaging code

Status: RESOLVED FIXED

(GeckoView :: General, defect)

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: 1. Convert GeckoRequest usages to events (v1)

Convert places where we use GeckoRequest (to get a callback from JS to
Java) to bundle events that use the built-in callback support.

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: 2. Convert SearchEngine observers to events (v1)

Convert the "SearchEngine:*" observers to events that go through
GlobalEventDispatcher.

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: 3. Change remaining Messaging calls to EventDispatcher calls (v1)

Convert calls in several places where we still use Messaging.* instead
of EventDispatcher.

Comment 4

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: 4. Convert remaining Robocop events to bundle events (v1)

Convert the remaining events used in Robocop to bundle events.

Comment 5

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: 5. Support other primitive types in event callback (v1)

Add support for byte, short, float, long, and char types as the response
object for event callbacks.

Comment 6

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: 6. Remove GeckoEventListener and NativeEventListener (v1)

Remove GeckoEventListener and NativeEventListener now that we uniformly
use BundleEventListener. Also remove related classes NativeJSContainer,
NativeJSObject, and GeckoRequest, as well as related tests and C++
code.

The "Messaging" object in Messaging.jsm is replaced with a dummy object
that redirect calls to the global and/or window event dispatcher.

Comment 7

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: 7. Add more callback tests to testEventDispatcher (v1)

Add more callback tests to testEventDispatcher,

1) Test for checking that the callback for a Gecko thread event,
dispatched from Gecko, is synchronous. We depend on this behavior in
several places where we require a "function call" style event.

2) Test for checking that callbacks accept a variety of data types as
the response object, including the standard types supported by
GeckoBundle, as well as primitive types that are convertible to standard
types.

Comment 8

[Geoff Brown [:gbrown]]

Comment on attachment 8831175 [details] [diff] [review]
4. Convert remaining Robocop events to bundle events (v1)

Review of attachment 8831175 [details] [diff] [review]:
-----------------------------------------------------------------

This all looks fine.

Be sure to push a try run with a few retries of all the robocop tests.

Comment 9

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8831172 [details] [diff] [review]
1. Convert GeckoRequest usages to events (v1)

Review of attachment 8831172 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/java/org/mozilla/gecko/javaaddons/JavaAddonManagerV1.java
@@ +190,5 @@
> +                            try {
> +                                final JSONObject wrapper = new JSONObject();
> +                                wrapper.put("response", response);
> +                                bundle = GeckoBundle.fromJSONObject(wrapper);
> +                            } catch (final Exception e) {

Isn't catching JSONException enough here?

Comment 10

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8831177 [details] [diff] [review]
6. Remove GeckoEventListener and NativeEventListener (v1)

Should ask you to review the Java bits

(In reply to Sebastian Kaspari (:sebastian) from comment #9)
> Comment on attachment 8831172 [details] [diff] [review]
> 1. Convert GeckoRequest usages to events (v1)
> 
> > +                            } catch (final Exception e) {
> 
> Isn't catching JSONException enough here?

Right

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ecb3d75e77db
1. Convert GeckoRequest usages to events; r=sebastian
https://hg.mozilla.org/integration/mozilla-inbound/rev/05e9876c741a
2. Convert SearchEngine observers to events; r=sebastian
https://hg.mozilla.org/integration/mozilla-inbound/rev/975d08403d3f
3. Change remaining Messaging calls to EventDispatcher calls; r=sebastian
https://hg.mozilla.org/integration/mozilla-inbound/rev/b398ba5f0379
4. Convert remaining Robocop events to bundle events; r=gbrown
https://hg.mozilla.org/integration/mozilla-inbound/rev/a196509ee1cb
5. Support other primitive types in event callback; r=snorp
https://hg.mozilla.org/integration/mozilla-inbound/rev/291ae1815d36
6. Remove GeckoEventListener and NativeEventListener; r=snorp r=sebastian
https://hg.mozilla.org/integration/mozilla-inbound/rev/595ec77d1498
7. Add more callback tests to testEventDispatcher; r=snorp

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ecb3d75e77db
https://hg.mozilla.org/mozilla-central/rev/05e9876c741a
https://hg.mozilla.org/mozilla-central/rev/975d08403d3f
https://hg.mozilla.org/mozilla-central/rev/b398ba5f0379
https://hg.mozilla.org/mozilla-central/rev/a196509ee1cb
https://hg.mozilla.org/mozilla-central/rev/291ae1815d36
https://hg.mozilla.org/mozilla-central/rev/595ec77d1498