Closed
Bug 1333736
Opened 7 years ago
Closed 7 years ago
Disable usage of new tab page now that loading about:blank twice is no longer an issue
Categories
(Remote Protocol :: Marionette, defect)
Tracking
(firefox52 fixed, firefox53 fixed, firefox54 fixed)
RESOLVED
FIXED
mozilla54
People
(Reporter: whimboo, Assigned: whimboo)
References
Details
Attachments
(1 file)
For the GeckoInstance we set the pref "browser.newtabpage.enabled" to True because bug 1312674 caused a hang when about:blank gets loaded twice. Given that this no longer an issue, we should revert this change.
Assignee | ||
Updated•7 years ago
|
Comment hidden (mozreview-request) |
Assignee | ||
Comment 2•7 years ago
|
||
The submitted patch works fine but causes test failures for Fennec. This is for test_about_blank_for_new_docshell which I tried to re-enable by modifying the test from opening a new window to a new tab. But no idea why that fails. I filed bug 1334095 to track it for re-enabling. https://treeherder.mozilla.org/#/jobs?repo=try&revision=dad5c1c2414f&filter-tier=1&filter-tier=2&filter-tier=3&selectedJob=71923495&bugfiler
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8830292 -
Flags: review?(mjzffr)
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8830292 [details] Bug 1333736 - Disable usage of new tab page by default. https://reviewboard.mozilla.org/r/107168/#review108908
Attachment #8830292 -
Flags: review?(mjzffr) → review+
Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a9afb304dbb6 Disable usage of new tab page by default. r=maja_zf
![]() |
||
Comment 6•7 years ago
|
||
Backed out for failing TestNavigate.test_about_blank_for_new_docshell and TestNavigate.test_focus_after_navigation: https://hg.mozilla.org/integration/autoland/rev/831c20c3086bf27da1ea8170090df58746caa152 Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=a9afb304dbb69dfab72128cf355f627f9af25828 Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=72602123&repo=autoland [task 2017-01-27T17:30:41.113117Z] 17:30:41 INFO - TEST-START | test_findelement_chrome.py TestElementsChrome.test_xpath [task 2017-01-27T17:30:41.442687Z] 17:30:41 INFO - TEST-PASS | test_findelement_chrome.py TestElementsChrome.test_xpath | took 330ms [task 2017-01-27T17:30:41.449403Z] 17:30:41 INFO - TEST-START | test_navigation.py TestNavigate.test_about_blank_for_new_docshell [task 2017-01-27T17:30:42.442069Z] 17:30:42 INFO - TEST-UNEXPECTED-FAIL | test_navigation.py TestNavigate.test_about_blank_for_new_docshell | AssertionError: u'http://127.0.0.1:51971/empty.html' != 'about:blank'
Flags: needinfo?(hskupin)
Assignee | ||
Comment 7•7 years ago
|
||
Strange. Everything was working fine in the original try push. Maybe the changes as landed via bug 1323185 caused this bustage. Lets see what we can find in the gecko.log: 1485538037072 Marionette TRACE conn956 -> [0,18,"switchToWindow",{"name":"421"}] 1485538037075 Marionette TRACE conn956 <- [1,18,null,{}] 1485538037077 Marionette TRACE conn956 -> [0,19,"getCurrentUrl",null] 1485538037087 Marionette TRACE conn956 <- [1,19,null,{"value":"http://127.0.0.1:42323/empty.html"}] So, yes. Opening the new tab opens the empty.html page, and the assertion for "about:blank" fails. I will have to get this adjusted by Monday. Sorry for the noise.
Flags: needinfo?(hskupin)
Comment hidden (mozreview-request) |
Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c60b3d435a5b Disable usage of new tab page by default. r=maja_zf
Comment 10•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/c60b3d435a5b
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Assignee | ||
Comment 11•7 years ago
|
||
Test-only patch which we would like to have uplifted to both aurora and beta. Thanks.
status-firefox52:
--- → affected
status-firefox53:
--- → affected
Whiteboard: [checkin-needed-aurora][checkin-needed-beta]
Comment 12•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/8e911bf5de82
Whiteboard: [checkin-needed-aurora][checkin-needed-beta] → [checkin-needed-beta]
Comment 13•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/d859990cc311
Whiteboard: [checkin-needed-beta]
Updated•7 months ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•