1333736 - Disable usage of new tab page now that loading about:blank twice is no longer an issue

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

For the GeckoInstance we set the pref "browser.newtabpage.enabled" to True because bug 1312674 caused a hang when about:blank gets loaded twice. Given that this no longer an issue, we should revert this change.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1333736 - Disable usage of new tab page by default.

Now that Marionette can load about:blank multiple times right after each
other there is no need to prevent using it when turning of the new tab page.

test_about_blank_for_new_docshell can also be updated by using a new tab for
the test. This also gives us a new docshell and can also be run for Fennec.

Review commit: https://reviewboard.mozilla.org/r/107168/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/107168/

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

The submitted patch works fine but causes test failures for Fennec. This is for test_about_blank_for_new_docshell which I tried to re-enable by modifying the test from opening a new window to a new tab. But no idea why that fails. I filed bug 1334095 to track it for re-enabling.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=dad5c1c2414f&filter-tier=1&filter-tier=2&filter-tier=3&selectedJob=71923495&bugfiler

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 8830292 [details]
Bug 1333736 - Disable usage of new tab page by default.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/107168/diff/1-2/

Comment 4

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8830292 [details]
Bug 1333736 - Disable usage of new tab page by default.

https://reviewboard.mozilla.org/r/107168/#review108908

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a9afb304dbb6
Disable usage of new tab page by default. r=maja_zf

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for failing TestNavigate.test_about_blank_for_new_docshell and TestNavigate.test_focus_after_navigation:

https://hg.mozilla.org/integration/autoland/rev/831c20c3086bf27da1ea8170090df58746caa152

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=a9afb304dbb69dfab72128cf355f627f9af25828
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=72602123&repo=autoland

[task 2017-01-27T17:30:41.113117Z] 17:30:41     INFO - TEST-START | test_findelement_chrome.py TestElementsChrome.test_xpath
[task 2017-01-27T17:30:41.442687Z] 17:30:41     INFO - TEST-PASS | test_findelement_chrome.py TestElementsChrome.test_xpath | took 330ms
[task 2017-01-27T17:30:41.449403Z] 17:30:41     INFO - TEST-START | test_navigation.py TestNavigate.test_about_blank_for_new_docshell
[task 2017-01-27T17:30:42.442069Z] 17:30:42     INFO - TEST-UNEXPECTED-FAIL | test_navigation.py TestNavigate.test_about_blank_for_new_docshell | AssertionError: u'http://127.0.0.1:51971/empty.html' != 'about:blank'

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Strange. Everything was working fine in the original try push. Maybe the changes as landed via bug 1323185 caused this bustage.

Lets see what we can find in the gecko.log:

1485538037072	Marionette	TRACE	conn956 -> [0,18,"switchToWindow",{"name":"421"}]
1485538037075	Marionette	TRACE	conn956 <- [1,18,null,{}]
1485538037077	Marionette	TRACE	conn956 -> [0,19,"getCurrentUrl",null]
1485538037087	Marionette	TRACE	conn956 <- [1,19,null,{"value":"http://127.0.0.1:42323/empty.html"}]

So, yes. Opening the new tab opens the empty.html page, and the assertion for "about:blank" fails. I will have to get this adjusted by Monday. Sorry for the noise.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 8830292 [details]
Bug 1333736 - Disable usage of new tab page by default.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/107168/diff/2-3/

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c60b3d435a5b
Disable usage of new tab page by default. r=maja_zf

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c60b3d435a5b

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Test-only patch which we would like to have uplifted to both aurora and beta. Thanks.

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/8e911bf5de82

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d859990cc311