Closed Bug 1333736 Opened 4 years ago Closed 4 years ago

Disable usage of new tab page now that loading about:blank twice is no longer an issue


(Testing :: Marionette, defect)

Version 3
Not set


(firefox52 fixed, firefox53 fixed, firefox54 fixed)

Tracking Status
firefox52 --- fixed
firefox53 --- fixed
firefox54 --- fixed


(Reporter: whimboo, Assigned: whimboo)




(1 file)

For the GeckoInstance we set the pref "browser.newtabpage.enabled" to True because bug 1312674 caused a hang when about:blank gets loaded twice. Given that this no longer an issue, we should revert this change.
Assignee: nobody → hskupin
Depends on: 1312674
The submitted patch works fine but causes test failures for Fennec. This is for test_about_blank_for_new_docshell which I tried to re-enable by modifying the test from opening a new window to a new tab. But no idea why that fails. I filed bug 1334095 to track it for re-enabling.
Attachment #8830292 - Flags: review?(mjzffr)
Comment on attachment 8830292 [details]
Bug 1333736 - Disable usage of new tab page by default.
Attachment #8830292 - Flags: review?(mjzffr) → review+
Pushed by
Disable usage of new tab page by default. r=maja_zf
Backed out for failing TestNavigate.test_about_blank_for_new_docshell and TestNavigate.test_focus_after_navigation:

Push with failures:
Failure log:

[task 2017-01-27T17:30:41.113117Z] 17:30:41     INFO - TEST-START | TestElementsChrome.test_xpath
[task 2017-01-27T17:30:41.442687Z] 17:30:41     INFO - TEST-PASS | TestElementsChrome.test_xpath | took 330ms
[task 2017-01-27T17:30:41.449403Z] 17:30:41     INFO - TEST-START | TestNavigate.test_about_blank_for_new_docshell
[task 2017-01-27T17:30:42.442069Z] 17:30:42     INFO - TEST-UNEXPECTED-FAIL | TestNavigate.test_about_blank_for_new_docshell | AssertionError: u'' != 'about:blank'
Flags: needinfo?(hskupin)
Strange. Everything was working fine in the original try push. Maybe the changes as landed via bug 1323185 caused this bustage.

Lets see what we can find in the gecko.log:

1485538037072	Marionette	TRACE	conn956 -> [0,18,"switchToWindow",{"name":"421"}]
1485538037075	Marionette	TRACE	conn956 <- [1,18,null,{}]
1485538037077	Marionette	TRACE	conn956 -> [0,19,"getCurrentUrl",null]
1485538037087	Marionette	TRACE	conn956 <- [1,19,null,{"value":""}]

So, yes. Opening the new tab opens the empty.html page, and the assertion for "about:blank" fails. I will have to get this adjusted by Monday. Sorry for the noise.
Flags: needinfo?(hskupin)
Pushed by
Disable usage of new tab page by default. r=maja_zf
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Test-only patch which we would like to have uplifted to both aurora and beta. Thanks.
Whiteboard: [checkin-needed-aurora][checkin-needed-beta]
Whiteboard: [checkin-needed-aurora][checkin-needed-beta] → [checkin-needed-beta]
You need to log in before you can comment on or make changes to this bug.