Temporary permissions remain after reloading all the pages using the tab context menu

RESOLVED FIXED in Firefox 54

Status

()

Firefox
Site Identity and Permission Panels
P1
normal
RESOLVED FIXED
4 months ago
3 months ago

People

(Reporter: Hani Yacoub, Assigned: Paolo, NeedInfo)

Tracking

(Blocks: 1 bug)

53 Branch
Firefox 54
Points:
---
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox53 affected, firefox54 fixed)

Details

(Whiteboard: [fxprivacy])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

4 months ago
Build ID: 20170125030214
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:54.0) Gecko/20100101 Firefox/54.0


[Affected versions]: 
Nightly 54.0a1

[Affected platforms]:
All platforms: Ubuntu 16.04 x64, Windows 10 x 64, Mac OS X 10.11

[Steps to reproduce]:
1. Go to permission.site and click on "Notification".
2. Uncheck "Remember this decision" and click on "Don't Allow".
3. Right click on the tab.
4. Click on "Reload All Tabs".

[Expected result]:
In the address bar near the "i" you the notification icon in a grey color and with a stripe over it shouldn't be displayed.
In control center under the Permissions "You have not granted this site any special permissions" message is displayed.

[Actual result]:
In the address bar near the "i" you see a notification icon that in a grey color and with a stripe over it.
In control center under permissions the status is Block Temporarily.

[Note]
It's also reproducible if you click on the URL and then press "Enter".
(Reporter)

Updated

4 months ago
Blocks: 1188147
(Reporter)

Updated

4 months ago
status-firefox53: --- → affected
status-firefox54: --- → affected
Yeah we should solve that, too.
Priority: -- → P1
Whiteboard: [fxprivacy]

Updated

4 months ago
Assignee: nobody → paolo.mozmail
Iteration: --- → 54.1 - Feb 6
Flags: qe-verify?

Updated

4 months ago
Iteration: 54.1 - Feb 6 → 54.2 - Feb 20
(Assignee)

Comment 2

4 months ago
I just looked into this. Why is this considered a bug?

I'd say that reloading all tabs shouldn't reset temporary permissions. As I understand it, the main use case for reloading all tabs is to recover from networking issues when you lose the connection temporarily or connect to a different network. This is different from reloading the page you're looking at manually, which may be an attempt to solve issues with the site.

I can add a test for what should happen in this case regardless.
Flags: needinfo?(philipp)
Whiteboard: [fxprivacy] → [fxprivacy][triage]
(Assignee)

Comment 3

4 months ago
We can always reset the temporary permissions for the currently selected tab only, but I'm not sure this command is common enough to warrant this special case.
I wouldn't say it's a big concern either way, the usability loss for the user is negligible. I'm leaning towards WONTFIX but we can also talk about it at triage.
(Assignee)

Comment 5

4 months ago
Well, I have a test patch we can land still.
Comment hidden (mozreview-request)
(Assignee)

Comment 7

4 months ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f940141a05e032a85ffe36df905b8fa95f5b5483

Comment 8

3 months ago
mozreview-review
Comment on attachment 8836019 [details]
Bug 1333741 - Add tests for temporary permissions when reloading all the pages using the tab context menu.

https://reviewboard.mozilla.org/r/111540/#review113220

Thanks! It's a good idea to have a test to not leave this as undefined behavior.
Attachment #8836019 - Flags: review?(jhofmann) → review+
(Assignee)

Updated

3 months ago
Flags: qe-verify? → qe-verify-
Whiteboard: [fxprivacy][triage] → [fxprivacy]

Comment 9

3 months ago
Pushed by paolo.mozmail@amadzone.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/67278f192c2b
Add tests for temporary permissions when reloading all the pages using the tab context menu. r=johannh
https://hg.mozilla.org/mozilla-central/rev/67278f192c2b
Status: NEW → RESOLVED
Last Resolved: 3 months ago
status-firefox54: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
You need to log in before you can comment on or make changes to this bug.