|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
Bug 1333741 - Add tests for temporary permissions when reloading all the pages using the tab context menu.
59 bytes, text/x-review-board-request
|Details | Review|
Build ID: 20170125030214 User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:54.0) Gecko/20100101 Firefox/54.0 [Affected versions]: Nightly 54.0a1 [Affected platforms]: All platforms: Ubuntu 16.04 x64, Windows 10 x 64, Mac OS X 10.11 [Steps to reproduce]: 1. Go to permission.site and click on "Notification". 2. Uncheck "Remember this decision" and click on "Don't Allow". 3. Right click on the tab. 4. Click on "Reload All Tabs". [Expected result]: In the address bar near the "i" you the notification icon in a grey color and with a stripe over it shouldn't be displayed. In control center under the Permissions "You have not granted this site any special permissions" message is displayed. [Actual result]: In the address bar near the "i" you see a notification icon that in a grey color and with a stripe over it. In control center under permissions the status is Block Temporarily. [Note] It's also reproducible if you click on the URL and then press "Enter".
Yeah we should solve that, too.
I just looked into this. Why is this considered a bug? I'd say that reloading all tabs shouldn't reset temporary permissions. As I understand it, the main use case for reloading all tabs is to recover from networking issues when you lose the connection temporarily or connect to a different network. This is different from reloading the page you're looking at manually, which may be an attempt to solve issues with the site. I can add a test for what should happen in this case regardless.
We can always reset the temporary permissions for the currently selected tab only, but I'm not sure this command is common enough to warrant this special case.
I wouldn't say it's a big concern either way, the usability loss for the user is negligible. I'm leaning towards WONTFIX but we can also talk about it at triage.
Well, I have a test patch we can land still.
Comment on attachment 8836019 [details] Bug 1333741 - Add tests for temporary permissions when reloading all the pages using the tab context menu. https://reviewboard.mozilla.org/r/111540/#review113220 Thanks! It's a good idea to have a test to not leave this as undefined behavior.
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/67278f192c2b Add tests for temporary permissions when reloading all the pages using the tab context menu. r=johannh