1334043 - Implement connected lifecycle callbacks for custom elements

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P3)

Description

[Edgar Chen [:edgar]]

https://html.spec.whatwg.org/multipage/scripting.html#concept-custom-element-definition-lifecycle-callbacks

Comment 1

[Jessica Jong [:jessica] (inactive)]

Attachment: Part 1: replace attached callback with connected callback, v1.

Comment 2

[Jessica Jong [:jessica] (inactive)]

Attachment: Part 2: make nsContentUtils::EnqueueLifecycleCallback static, v1.

Comment 3

[Jessica Jong [:jessica] (inactive)]

Attachment: Part 3: update test cases, v1.

Comment 4

[Jessica Jong [:jessica] (inactive)]

Olli, feel free to review these when you're available. :)

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8904571 [details] [diff] [review]
Part 2: make nsContentUtils::EnqueueLifecycleCallback static, v1.

s/windows object/window object/

Things are getting simpler, good.

Comment 6

[Jessica Jong [:jessica] (inactive)]

Attachment: Part 4: connected callback while upgrading, v1.

I forgot to add this part, I'll merge into Part 1 and Part 4 once it's reviewed.

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8904744 [details] [diff] [review]
Part 4: connected callback while upgrading, v1.

># HG changeset patch
># Parent  fd2411bd35dbdc1a952a7300910ce028a6d3e7cd
>Bug 1334043 - Part 4: Enqueue connected callback if element is connected while upgrading. r=smaug
>
>MozReview-Commit-ID: DTsEDZG978L
>
>diff --git a/dom/base/CustomElementRegistry.cpp b/dom/base/CustomElementRegistry.cpp
>--- a/dom/base/CustomElementRegistry.cpp
>+++ b/dom/base/CustomElementRegistry.cpp
>@@ -939,17 +939,20 @@ CustomElementRegistry::Upgrade(Element* 
>         nsContentUtils::EnqueueLifecycleCallback(nsIDocument::eAttributeChanged,
>                                                  aElement,
>                                                  &args, aDefinition);
>       }
>     }
>   }
> 
>   // Step 4.
>-  // TODO: Bug 1334043 - Implement connected lifecycle callbacks for custom elements
>+  if (aElement->GetComposedDoc()) {
IsInComposedDoc

Comment 8

[Jessica Jong [:jessica] (inactive)]

This and the other custom elements patches will land after v57 branching, before end of next week hopefully.

Comment 9

[Jessica Jong [:jessica] (inactive)]

Attachment: Part 1: replace attached callback with connected callback, v2.

Rebased and added part of Part 4 (attachment 8904744 [details] [diff] [review]).

Comment 10

[Jessica Jong [:jessica] (inactive)]

Attachment: Part 2: make nsContentUtils::EnqueueLifecycleCallback static, v2.

rebased.

Comment 11

[Jessica Jong [:jessica] (inactive)]

Attachment: Part 3: update test cases, v2.

Rebased and added part of Part 4 (attachment 8904744 [details] [diff] [review] [diff] [review]).

Comment 12

[Jessica Jong [:jessica] (inactive)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a7aa519da6c9490d8c554d18219d2439f4930b44&group_state=expanded

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/157b2ba57ad2
Part 1: Replace attached callback (v0) with connected callback (v1). r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/f0b6fd276560
Part 2: Make nsContentUtils::EnqueueLifecycleCallback static. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/b900023d886c
Part 3: Update tests for connected callback. r=smaug

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/157b2ba57ad2
https://hg.mozilla.org/mozilla-central/rev/f0b6fd276560
https://hg.mozilla.org/mozilla-central/rev/b900023d886c