1334127 - Upgrade Firefox 54 to NSS 3.30

Status: RESOLVED FIXED

(Core :: Security: PSM, defect, P1)

Description

[Franziskus Kiefer [:franziskus]]

Tracking NSS 3.30 for Firefox 54.

Comment 1

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ef2a7e15295b
bump NSS version to 3.30 in old-configure.in, r=me
https://hg.mozilla.org/integration/mozilla-inbound/rev/0fc3d0ffe71e
land NSS dbbf303cf467, r=me

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ef2a7e15295b
https://hg.mozilla.org/mozilla-central/rev/0fc3d0ffe71e

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/18c7c3e49639
land NSS 87188da8b352, r=me

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/18c7c3e49639

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1518380b015a
land NSS 650e5f6cb617, r=me

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1518380b015a

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ef2f2b1d4773
land NSS 0a7ba014dbb3, r=me

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ef2f2b1d4773

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8ea557ab6b8d
land NSS 0750d7a0402b, r=me

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8ea557ab6b8d

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fed6784a92cf
land NSS e3bca65235d5, r=me

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/fed6784a92cf

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e9dca250a3d3
land NSS 2acb84c21d9d, r=me

Comment 14

[Iris Hsiao [:ihsiao]]

sorry had to back this out for bustage, https://treeherder.mozilla.org/logviewer.html#?job_id=76210427&repo=mozilla-inbound&lineNumber=11923 and https://treeherder.mozilla.org/logviewer.html#?job_id=76210495&repo=mozilla-inbound&lineNumber=12678
https://hg.mozilla.org/integration/mozilla-inbound/rev/d3f5466ed29b

Comment 15

[Iris Hsiao [:ihsiao]]

I think the two failures also related to your patches, https://treeherder.mozilla.org/logviewer.html#?job_id=76214859&repo=mozilla-inbound&lineNumber=2437 and https://treeherder.mozilla.org/logviewer.html#?job_id=76214802&repo=mozilla-inbound&lineNumber=2406

Comment 16

[Franziskus Kiefer [:franziskus]]

This is busted due to [1] (bug 1334976) and [2] (bug 1054373)

[1] https://hg.mozilla.org/projects/nss/rev/29858a467f45
[2] https://hg.mozilla.org/projects/nss/rev/92e0af39805c

Comment 17

[Kai Engert [:KaiE:]]

The windows build failed, because the new code depends on a new exported symbol, and firefox uses its own list of exported symbols (PK11_HasAttributeSet). I'll attach a patch for that, which probably needs to be landed at the same time as the new NSS snapshot.

Comment 18

[Kai Engert [:KaiE:]]

Attachment: 1334127-PK11_HasAttributeSet.patch

Comment 19

[Franziskus Kiefer [:franziskus]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ae7d15735087

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6d5a6e5b4716
land NSS 01d6c0dff06f, r=me
https://hg.mozilla.org/integration/mozilla-inbound/rev/0189f0cccfdc
update firefox nss.symbols, r=franziskus

Comment 21

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6d5a6e5b4716
https://hg.mozilla.org/mozilla-central/rev/0189f0cccfdc

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e0ab3ae16c94
land NSS 93b99b0936d3, r=me

Comment 23

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e0ab3ae16c94

Comment 24

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5b35dfe81b68
land NSS 6511e19a2c6c, r=me

Comment 25

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5b35dfe81b68

Comment 26

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bcb46d32449b
land NSS dec8c06d7ed9, r=me

Comment 27

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/bcb46d32449b

Comment 28

[Tim Taubert [:ttaubert] (inactive)]

Attachment: update to 3.30

Comment 29

[Julien Cristau [:jcristau]]

Comment on attachment 8847150 [details]
update to 3.30

nss update, aurora54+

Does this mean the leave-open keyword can be removed?

Comment 30

[Franziskus Kiefer [:franziskus]]

Yep, I removed it. We can close this bug when 3.30 RTM landed in aurora.

Comment 31

[Carsten Book [:Tomcat]]

kai: are you going to to this uplift ?

Comment 32

[Kai Engert [:KaiE:]]

done:
https://hg.mozilla.org/releases/mozilla-aurora/rev/f02ada834be185916ec50ad4e58d834aa5e75bde