1334227 - Crash [@ nsFloatManager::FloatInfo::FloatInfo ]

Status: VERIFIED FIXED

(Core :: Layout: Floats, defect)

Description

[Sebastian Zartner [:sebo]]

With the changes of bug 1326406 Firefox crashes on https://css-tricks.com/almanac/properties/s/shape-outside/. See this crash report:

https://crash-stats.mozilla.com/report/index/fc698b6f-5239-4f86-8f16-e2ef42170126

Sebastian

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Presumably mShapeInfo is null because we hit one of the types that we parse but don't yet implement?

Given that this feature is pref'd off, even on nightly, I don't think this is a big deal.  I think this should go away once all the types are implemented.

Comment 2

[Sebastian Zartner [:sebo]]

(In reply to David Baron :dbaron: ⌚️UTC-8 from comment #1)
> Presumably mShapeInfo is null because we hit one of the types that we parse
> but don't yet implement?

You're right. It's crashing when using the polygon() or the inset() function. Test case:
data:text/html,<div style="shape-outside:polygon(0 0, 0 200px, 300px 600px);float:left;"></div>

Sebastian

Comment 3

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1334227 - Early return in unimplemented shape-outside cases.

Review commit: https://reviewboard.mozilla.org/r/109042/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/109042/

Comment 4

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8832776 [details]
Bug 1334227 - Early return in unimplemented shape-outside cases.

https://reviewboard.mozilla.org/r/109042/#review110178

::: layout/generic/nsFloatManager.cpp:721
(Diff revision 1)
> +  // XXX: Remove this null check once all the shape-outside values are
> +  // implemented.
> +  if (!mShapeInfo) {
> +    return;
> +  }

I'd prefer you leave the assertion here, and early return in the two unimplemented cases.

Comment 5

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Comment on attachment 8832776 [details]
Bug 1334227 - Early return in unimplemented shape-outside cases.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/109042/diff/1-2/

Comment 6

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8832776 [details]
Bug 1334227 - Early return in unimplemented shape-outside cases.

https://reviewboard.mozilla.org/r/109042/#review110182

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/abc3cb8fff3e
Early return in unimplemented shape-outside cases. r=xidorn

Comment 8

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

xidorn, thank you for the review.

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/abc3cb8fff3e

Comment 10

[Sebastian Zartner [:sebo]]

Works with Nightly 2017-02-03, thanks for the fast fix!

Sebastian