Closed Bug 1334261 Opened 4 years ago Closed 4 years ago

Remove more newURI's null parameters

Categories

(Firefox :: General, defect)

53 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 54
Tracking Status
firefox54 --- fixed

People

(Reporter: florian, Assigned: florian)

References

Details

Attachments

(3 files, 1 obsolete file)

Attached file xpcshell script (obsolete) —
The script I used in bug 1329182 missed the following cases:
- files with .html or .xul extensions
- newURI calls with the . on the previous line.

The attached xpcshell script (based on the version I used in bug 1334199) handles these case.
Attachment #8830915 - Flags: review?(jaws)
Attached file xpcshell script
The previous script missed parameters that were provided as "" instead of null.
Attachment #8830903 - Attachment is obsolete: true
Comment on attachment 8830915 [details] [diff] [review]
script-generated patch

Review of attachment 8830915 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me
Attachment #8830915 - Flags: review?(jaws) → review+
Attached patch eslint rule fixSplinter Review
Attachment #8830930 - Flags: review?(jaws)
Attachment #8830930 - Flags: review?(jaws) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/c0be583a19b635e94b3e7801497d09d03daa68b7
Bug 1334261 - make the no-useless-parameters rule reject newURI call with an empty string as the last parameter, r=jaws.

https://hg.mozilla.org/integration/mozilla-inbound/rev/a58d0d69502bbe43f2d468d08b2adeda458f630f
Bug 1334261 - script-generated patch to remove more newURI null parameters, r=jaws.
https://hg.mozilla.org/mozilla-central/rev/c0be583a19b6
https://hg.mozilla.org/mozilla-central/rev/a58d0d69502b
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
You need to log in before you can comment on or make changes to this bug.