1334261 - Remove more newURI's null parameters

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Florian Quèze [:florian]]

Attachment: xpcshell script

The script I used in bug 1329182 missed the following cases:
- files with .html or .xul extensions
- newURI calls with the . on the previous line.

The attached xpcshell script (based on the version I used in bug 1334199) handles these case.

Comment 1

[Florian Quèze [:florian]]

Attachment: script-generated patch

Comment 2

[Florian Quèze [:florian]]

Attachment: xpcshell script

The previous script missed parameters that were provided as "" instead of null.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8830915 [details] [diff] [review]
script-generated patch

Review of attachment 8830915 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me

Comment 4

[Florian Quèze [:florian]]

Attachment: eslint rule fix

Comment 5

[Florian Quèze [:florian]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c0be583a19b635e94b3e7801497d09d03daa68b7
Bug 1334261 - make the no-useless-parameters rule reject newURI call with an empty string as the last parameter, r=jaws.

https://hg.mozilla.org/integration/mozilla-inbound/rev/a58d0d69502bbe43f2d468d08b2adeda458f630f
Bug 1334261 - script-generated patch to remove more newURI null parameters, r=jaws.

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c0be583a19b6
https://hg.mozilla.org/mozilla-central/rev/a58d0d69502b