Closed Bug 1334729 Opened 8 years ago Closed 8 years ago

Intermittent toolkit/components/startup/tests/browser/browser_bug511456.js | Should have seen a prompt dialog -

Categories

(Toolkit :: Startup and Profile System, defect)

Product:
Toolkit
Component:
Startup and Profile System
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: jmaher)

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell disabled])

Attachments

(1 file)

disable the test on linux !e10s
681 bytes, patch
benjamin
: review+
Details | Diff | Splinter Review
Frequency uptick is likely fallout from the upgrade to Ubuntu 16.04 in bug 1319863.
Flags: needinfo?(jmaher)
thanks for adding me to this bug- I will keep an eye on this and this kind of feedback is great to get.
Flags: needinfo?(jmaher)
(In reply to Sebastian Hengst [:aryx][:archaeopteryx] (needinfo on intermittent or backout) from comment #3) > Frequency uptick is likely fallout from the upgrade to Ubuntu 16.04 in bug 1319863. Most tests are running fine though, so I don't think we'll go back to Ubuntu 12. This is now very frequent - on track for the most frequent failure. Failures are (linux && !e10s && !debug). Screenshots consistently show a prompt, "This page is asking you to confirm that you want to leave..." [task 2017-05-04T16:48:58.455857Z] 16:48:58 INFO - GECKO(3192) | 1493916538453 Marionette INFO Listening on port 2828 [task 2017-05-04T16:49:00.461295Z] 16:49:00 INFO - *** Start BrowserChrome Test Results *** [task 2017-05-04T16:49:00.619198Z] 16:49:00 INFO - checking window state [task 2017-05-04T16:49:00.756982Z] 16:49:00 INFO - TEST-START | toolkit/components/startup/tests/browser/browser_bug511456.js [task 2017-05-04T16:49:04.965473Z] 16:49:04 INFO - GECKO(3192) | TEST-UNEXPECTED-FAIL | unknown test url | Waited too long for window with dialog to focus [task 2017-05-04T16:49:04.982539Z] 16:49:04 INFO - TEST-INFO | started process screentopng [task 2017-05-04T16:49:06.209875Z] 16:49:06 INFO - TEST-INFO | screentopng: exit 0 [task 2017-05-04T16:49:06.213672Z] 16:49:06 INFO - Buffered messages logged at 16:49:01 [task 2017-05-04T16:49:06.217846Z] 16:49:06 INFO - Console message: [JavaScript Error: "The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must be declared in the document or in the transfer protocol." {file: "http://example.com/browser/toolkit/components/startup/tests/browser/beforeunload.html" line: 0}] [task 2017-05-04T16:49:06.220222Z] 16:49:06 INFO - Buffered messages finished [task 2017-05-04T16:49:06.222345Z] 16:49:06 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/startup/tests/browser/browser_bug511456.js | Should have seen a prompt dialog - [task 2017-05-04T16:49:06.225460Z] 16:49:06 INFO - Stack trace: [task 2017-05-04T16:49:06.229655Z] 16:49:06 INFO - chrome://mochitests/content/browser/toolkit/components/startup/tests/browser/browser_bug511456.js:test/</<:34 [task 2017-05-04T16:49:06.234853Z] 16:49:06 INFO - TEST-PASS | toolkit/components/startup/tests/browser/browser_bug511456.js | Shouldn't have closed the additional window - [task 2017-05-04T16:49:06.237924Z] 16:49:06 INFO - GECKO(3192) | MEMORY STAT vsizeMaxContiguous not supported in this build configuration. [task 2017-05-04T16:49:06.240291Z] 16:49:06 INFO - GECKO(3192) | MEMORY STAT | vsize 1950MB | residentFast 242MB | heapAllocated 109MB [task 2017-05-04T16:49:06.243066Z] 16:49:06 INFO - TEST-OK | toolkit/components/startup/tests/browser/browser_bug511456.js | took 4909ms
is this an issue with screenshots which recently landed?
at this rate we should disable this test.
:bsmedberg, as triage owner for this component, can you find someone to look into fixing this test which is failing so frequently? If we cannot find someone early next week, I will move to disable this test so it isn't so urgent and someone on the startup and profile system team can fix this when there is adequate time.
Flags: needinfo?(benjamin)
Whiteboard: [stockwell needswork]
(In reply to Geoff Brown [:gbrown] from comment #10) > Screenshots consistently show a prompt, "This page is asking you to confirm > that you want to leave..." I don’t have time to look for it now, but I think that dialogue can be controlled with a preference?
This appears to be Linux-specific correct, correct jmaher? I am not convinced that this is a problem with the test; this could easily be a problem with the code itself, or its behavior on Linux. The test is waiting for the condition Services.focus.activeWindow == browser.ownerGlobal which likely means that there is a problem raising the correct browser window, or noticing that it was raised, or something like that. But this is Linux and focus, which is a pretty terrible combination in general. ato, I don't understand what you're saying. This test is a test for the behavior of that dialog, so suppressing it doesn't make any sense.
Flags: needinfo?(benjamin) → needinfo?(jmaher)
githanks for the information :bsmedberg. This is linux only and shows up on opt/pgo, but in non-e10s. Given the high frequency of failures, I would say we need to fix the test/product/os asap, or disable this test to reduce the pain and pressure to fix. As this is not seen on e10s runs, there is diminishing value in fixing this to run for 3 months until we disable the test when 57 shows up.
Flags: needinfo?(jmaher) → needinfo?(benjamin)
If this test is running/passing on Linux-e10s, please feel free to disabled it for Linux/non-e10s only. As you said, quickly diminishing returns.
Flags: needinfo?(benjamin)
Assignee: nobody → jmaher
Status: NEW → ASSIGNED
Attachment #8865568 - Flags: review?(benjamin)
Attachment #8865568 - Flags: review?(benjamin) → review+
Pushed by jmaher@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/b855ad7415cb Intermittent toolkit/components/startup/tests/browser/browser_bug511456.js. disable on linux !e10s. r=bsmedberg
Whiteboard: [stockwell needswork] → [stockwell disabled]
https://hg.mozilla.org/mozilla-central/rev/b855ad7415cb
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: