1334860 - Remove WinXP-only ClearType prefs ( gfx.font_rendering.cleartype.use_for_downloadable_fonts )

Status: RESOLVED FIXED

(Core :: Graphics: Text, defect, P3)

Description

[Masatoshi Kimura [:emk]]

Basically this reverts bug 504698 (except for bug 507988 stuff).

Comment 1

[Masatoshi Kimura [:emk]]

Attachment: Bug 1334860 - Remove WinXP-only ClearType prefs.

Review commit: https://reviewboard.mozilla.org/r/108028/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/108028/

Comment 2

[Masatoshi Kimura [:emk]]

Review ping.

Comment 3

[Jonathan Kew [:jfkthame]]

Comment on attachment 8831497 [details]
Bug 1334860 - Remove WinXP-only ClearType prefs.

https://reviewboard.mozilla.org/r/108028/#review111468

Good to see this cleaned up! Sorry about the delay.

::: gfx/thebes/gfxGDIFontList.cpp:279
(Diff revision 1)
>      // a cairo transform to create fake italic (oblique)
>      if (mIsDataUserFont) {
>          aLogFont->lfItalic = 0;
>      }
>  
> -    aLogFont->lfQuality = (aUseCleartype ? CLEARTYPE_QUALITY : DEFAULT_QUALITY);
> +    aLogFont->lfQuality = DEFAULT_QUALITY;

This line can be removed altogether, as the mLogFont.lfQuality field was initialized to DEFAULT_QUALITY.

Comment 4

[Masatoshi Kimura [:emk]]

Comment on attachment 8831497 [details]
Bug 1334860 - Remove WinXP-only ClearType prefs.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/108028/diff/1-2/

Comment 5

[Masatoshi Kimura [:emk]]

Comment on attachment 8831497 [details]
Bug 1334860 - Remove WinXP-only ClearType prefs.

https://reviewboard.mozilla.org/r/108028/#review111468

> This line can be removed altogether, as the mLogFont.lfQuality field was initialized to DEFAULT_QUALITY.

Removed.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f3f3c165c484
Remove WinXP-only ClearType prefs. r=jfkthame

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f3f3c165c484