1334956 - devtools/client/framework/options-panel.css uses float: inline-start, will cause browser_parsable_css.js to permafail on Gecko 53 merge to beta on March 6th

Status: RESOLVED FIXED

(DevTools :: Framework, defect)

Description

[Phil Ringnalda (:philor)]

inline-start as a value for float is behind the pref layout.css.float-logical-values.enabled, which is still disabled on beta_or_release, so https://hg.mozilla.org/releases/mozilla-aurora/annotate/d859e69475796f76214f07c6d133c3a1f325156c/devtools/client/framework/options-panel.css#l18 is going to cause browser_parsable_css.js to be permaorange when 53 merges to beta on 2017-03-07.

Oh, and it also will stop working.

[Tracking Requested - why for this release]: permanently failing tests on merge to mozilla-beta

Comment 1

[Phil Ringnalda (:philor)]

Merge the 6th, release the 7th.

Comment 2

[Tomer Cohen :tomer]

Attachment: Bug 1334956 - devtools/client/framework/options-panel.css uses float: inline-start

Review commit: https://reviewboard.mozilla.org/r/108214/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/108214/

Comment 3

[Tomer Cohen :tomer]

Comment on attachment 8831671 [details]
Bug 1334956 - devtools/client/framework/options-panel.css uses float: inline-start

This should fix beta, unless you prefer to backout the change instead.

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8831671 [details]
Bug 1334956 - devtools/client/framework/options-panel.css uses float: inline-start

https://reviewboard.mozilla.org/r/108214/#review109300

Thanks, didn't realize it was preffed off for certain channels.

Comment 5

[Tomer Cohen :tomer]

(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #4)
> Thanks, didn't realize it was preffed off for certain channels.
Me as well. This is very difficult to debug when it is preffed on on your dev environment but not on production, and I am not sure if nightly tests could catch automatically.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/33a7ad19a335
devtools/client/framework/options-panel.css uses float: inline-start r=jryans

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/33a7ad19a335

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Please request Aurora approval on this at your earliest convenience :)

Comment 9

[Tomer Cohen :tomer]

Comment on attachment 8831671 [details]
Bug 1334956 - devtools/client/framework/options-panel.css uses float: inline-start

Approval Request Comment
[Feature/Bug causing the regression]: bug 1335010
[User impact if declined]: test failures
[Is this code covered by automated tests?]: no, but it cause failures due to unimplemented keywords.  
[Has the fix been verified in Nightly?]: yes.
[Needs manual test from QE? If yes, steps to reproduce]: probably not
[List of other uplifts needed for the feature/fix]: no dependencies beside bug 1335010 which this patch fix.
[Is the change risky?]: not too much.
[Why is the change risky/not risky?]: Just backporting CSS code to use :dir().
[String changes made/needed]:

Comment 10

[Tomer Cohen :tomer]

Please ignore my previous comment, as I've mentioned the wrong bug. I'm Sorry for the inconvenience. 

Approval Request Comment
[Feature/Bug causing the regression]: bug 1323504
[User impact if declined]: test failures
[Is this code covered by automated tests?]: no, but it cause failures due to unimplemented keywords.  
[Has the fix been verified in Nightly?]: yes.
[Needs manual test from QE? If yes, steps to reproduce]: probably not
[List of other uplifts needed for the feature/fix]: no dependencies beside bug 1323504 which this patch fix.
[Is the change risky?]: not too much.
[Why is the change risky/not risky?]: Just backporting CSS code to use :dir().
[String changes made/needed]:

Comment 11

[Gerry Chang [:gchang]]

Comment on attachment 8831671 [details]
Bug 1334956 - devtools/client/framework/options-panel.css uses float: inline-start

Fix test failures. Aurora53+.

Comment 12

[Gerry Chang [:gchang]]

Track 53+ as this will happen when merging to mozilla-beta.

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/47684515b538