Closed Bug 1334961 Opened 3 years ago Closed 3 years ago
Layer-1c .html will be permaorange when Gecko 53 merges to beta on 2017-03-06
59 bytes, text/x-review-board-request
https://treeherder.mozilla.org/logviewer.html#?job_id=72918933&repo=try (and the same on every other platform, and every other flavor of reftests), must be depending on something that's behind a RELEASE_OR_BETA ifdef or pref flip. [Tracking Requested - why for this release]: permaorange and a closed tree on the merge to beta
hi Astley, do we skip this test as well?
Flags: needinfo?(cku) → needinfo?(aschen)
Boy, you burn the hell out of reftests for a couple of releases, and suddenly everyone thinks every failure in a file with the string "mask" in the name is your fault for all time. This is Gecko 53, masking is enabled. Only in paint-on-maskLayer-1c.html, the only test which is failing, you used clip-path: inset, a clip-path-shape, and on beta and release layout.css.clip-path-shapes.enabled is set to false, so you need to set it to true for that test.
Flags: needinfo?(aschen) → needinfo?(cku)
ic... it is is a Aurora-as-beta test build, but is still an aurora build.
Comment on attachment 8833751 [details] Bug 1334961 - Turn on clip-path-basic-shapes for paint-on-maskLayer-1c.html. https://reviewboard.mozilla.org/r/109920/#review110870
Attachment #8833751 - Flags: review?(mstange) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/d0ef386d1808 Turn on clip-path-basic-shapes for paint-on-maskLayer-1c.html. r=mstange
Comment on attachment 8833751 [details] Bug 1334961 - Turn on clip-path-basic-shapes for paint-on-maskLayer-1c.html. Approval Request Comment [Feature/Bug causing the regression]: Bug 1313276 [User impact if declined]: paint-on-maskLayer-1c.html test case failure when Gecko 53 merge to beta [Is this code covered by automated tests?]: yes [Has the fix been verified in Nightly?]: yes [Needs manual test from QE? If yes, steps to reproduce]: no [List of other uplifts needed for the feature/fix]: [Is the change risky?]: no [Why is the change risky/not risky?]: impact reftest only [String changes made/needed]: nan
You don't actually need approval-aurora for test-only fixes. https://hg.mozilla.org/releases/mozilla-aurora/rev/553ed2dadb84860cccc6541bfec86dec499a67fc
You need to log in before you can comment on or make changes to this bug.