reftests/svg/paint-on-maskLayer-1c.html will be permaorange when Gecko 53 merges to beta on 2017-03-06

RESOLVED FIXED in Firefox 53

Status

()

Core
Layout
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: philor, Assigned: u459114)

Tracking

53 Branch
mozilla54
Points:
---

Firefox Tracking Flags

(firefox51 unaffected, firefox52 unaffected, firefox53? fixed, firefox54 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

a year ago
https://treeherder.mozilla.org/logviewer.html#?job_id=72918933&repo=try (and the same on every other platform, and every other flavor of reftests), must be depending on something that's behind a RELEASE_OR_BETA ifdef or pref flip.

[Tracking Requested - why for this release]: permaorange and a closed tree on the merge to beta
(Reporter)

Updated

a year ago
Duplicate of this bug: 1336449
(Reporter)

Updated

a year ago
Flags: needinfo?(cku)
(Assignee)

Comment 2

a year ago
hi Astley, do we skip this test as well?
Flags: needinfo?(cku) → needinfo?(aschen)
(Reporter)

Comment 3

a year ago
Boy, you burn the hell out of reftests for a couple of releases, and suddenly everyone thinks every failure in a file with the string "mask" in the name is your fault for all time.

This is Gecko 53, masking is enabled. Only in paint-on-maskLayer-1c.html, the only test which is failing, you used clip-path: inset, a clip-path-shape, and on beta and release layout.css.clip-path-shapes.enabled is set to false, so you need to set it to true for that test.
Flags: needinfo?(aschen) → needinfo?(cku)
(Assignee)

Updated

a year ago
Assignee: nobody → cku
Flags: needinfo?(cku)
Comment hidden (mozreview-request)
(Assignee)

Comment 5

a year ago
ic... it is is a Aurora-as-beta test build, but is still an aurora build.
(Assignee)

Updated

a year ago
Attachment #8833751 - Flags: review?(mstange)

Comment 7

a year ago
mozreview-review
Comment on attachment 8833751 [details]
Bug 1334961 - Turn on clip-path-basic-shapes for paint-on-maskLayer-1c.html.

https://reviewboard.mozilla.org/r/109920/#review110870
Attachment #8833751 - Flags: review?(mstange) → review+

Comment 8

a year ago
Pushed by cku@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d0ef386d1808
Turn on clip-path-basic-shapes for paint-on-maskLayer-1c.html. r=mstange
(Assignee)

Comment 9

a year ago
Comment on attachment 8833751 [details]
Bug 1334961 - Turn on clip-path-basic-shapes for paint-on-maskLayer-1c.html.

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1313276
[User impact if declined]: paint-on-maskLayer-1c.html test case failure when Gecko 53 merge to beta
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]:  no
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]: no
[Why is the change risky/not risky?]: impact reftest only
[String changes made/needed]: nan
Attachment #8833751 - Flags: approval-mozilla-aurora?
(Reporter)

Comment 10

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d0ef386d1808
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox54: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
(Reporter)

Comment 11

a year ago
You don't actually need approval-aurora for test-only fixes.

https://hg.mozilla.org/releases/mozilla-aurora/rev/553ed2dadb84860cccc6541bfec86dec499a67fc
status-firefox53: affected → fixed
(Reporter)

Updated

a year ago
Attachment #8833751 - Flags: approval-mozilla-aurora?
You need to log in before you can comment on or make changes to this bug.