reftests/svg/paint-on-maskLayer-1c.html will be permaorange when Gecko 53 merges to beta on 2017-03-06

RESOLVED FIXED in Firefox 53



3 years ago
3 years ago


(Reporter: philor, Assigned: u459114)


53 Branch
Dependency tree / graph

Firefox Tracking Flags

(firefox51 unaffected, firefox52 unaffected, firefox53? fixed, firefox54 fixed)



(1 attachment) (and the same on every other platform, and every other flavor of reftests), must be depending on something that's behind a RELEASE_OR_BETA ifdef or pref flip.

[Tracking Requested - why for this release]: permaorange and a closed tree on the merge to beta
Duplicate of this bug: 1336449
Flags: needinfo?(cku)
hi Astley, do we skip this test as well?
Flags: needinfo?(cku) → needinfo?(aschen)
Boy, you burn the hell out of reftests for a couple of releases, and suddenly everyone thinks every failure in a file with the string "mask" in the name is your fault for all time.

This is Gecko 53, masking is enabled. Only in paint-on-maskLayer-1c.html, the only test which is failing, you used clip-path: inset, a clip-path-shape, and on beta and release layout.css.clip-path-shapes.enabled is set to false, so you need to set it to true for that test.
Flags: needinfo?(aschen) → needinfo?(cku)
Assignee: nobody → cku
Flags: needinfo?(cku)
ic... it is is a Aurora-as-beta test build, but is still an aurora build.
Attachment #8833751 - Flags: review?(mstange)
Comment on attachment 8833751 [details]
Bug 1334961 - Turn on clip-path-basic-shapes for paint-on-maskLayer-1c.html.
Attachment #8833751 - Flags: review?(mstange) → review+
Pushed by
Turn on clip-path-basic-shapes for paint-on-maskLayer-1c.html. r=mstange
Comment on attachment 8833751 [details]
Bug 1334961 - Turn on clip-path-basic-shapes for paint-on-maskLayer-1c.html.

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1313276
[User impact if declined]: paint-on-maskLayer-1c.html test case failure when Gecko 53 merge to beta
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]:  no
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]: no
[Why is the change risky/not risky?]: impact reftest only
[String changes made/needed]: nan
Attachment #8833751 - Flags: approval-mozilla-aurora?
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Attachment #8833751 - Flags: approval-mozilla-aurora?
You need to log in before you can comment on or make changes to this bug.