1334997 - 'Add Search Engine' option not displayed after adding a custom search engine

Status: VERIFIED FIXED

(Firefox for iOS :: General, defect, P2)

Description

[Catalin Suciu [:csuciu]]

iPad Air 2 (10.2)/iPhone 6 Plus (10.2)
master 51abcc7

1. Go to Firefox Settings => Search => Add Search Engine 
2. Type the Title and the URL of a custom search engine and 'Save'

Result: When going back to the Search settings screen after adding a custom search engine, the 'Add Search Engine' option is missing. The option will be available again after going into edit mode or after re-entering Search settings

Comment 1

[Pushkar]

Hey, I worked on this view in 1299535, and should be able to fix this. Assign this to me?
I'll also look into Bug 1334689 and see if I can figure the crash as well.

Comment 2

[Catalin Suciu [:csuciu]]

Hey Pushkar, sure, I'll assign the bugs to you. Thanks for contributing.

Comment 3

[Pushkar]

You're welcome! Sorry, I've been a bit busy lately.

On XCode 8.2.1, for some reason I'm unable to get the master branch to build.
I remember it asking me to convert to latest swift syntax when I was working on another bug in December, and it used to build after that.
That does not seem to be the case now.
Am I missing something? Should I fork from a branch other than master? Please let me know.

Comment 4

[Catalin Suciu [:csuciu]]

Pushkar, you should now be able to build the master branch using Xcode 8.2.1 (after converting to latest swift syntax). Let us now if you have any other issues.

Comment 5

[Karthik]

Attachment: Pull request

Comment 6

[Karthik]

Since there was no progress on this bug, I have picked it. I have created a Pull request for this.

Comment 7

[Farhan Patel [:farhan]]

Comment on attachment 8871343 [details] [review]
Pull request

Left feedback in GH

Comment 8

[Karthik]

Updated the Pull request as per suggested changes.

Comment 9

[Farhan Patel [:farhan]]

https://github.com/mozilla-mobile/firefox-ios/commit/c85027eaa068206b4be76edfaf36d81ab1c59e4c

Comment 10

[Simon Basca [:SimonB]]

Verifying as fix on master c85027eaa0.

Comment 11

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Uplifted to v8.x

Comment 12

[Simon Basca [:SimonB]]

Verifying as fix on 8.1(4811).