Closed
Bug 1335220
Opened 8 years ago
Closed 8 years ago
[e10s] minimumIncrement is not implemented on Windows accessible proxy.
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla54
| Tracking | Status | |
|---|---|---|
| firefox54 | --- | fixed |
People
(Reporter: eeejay, Assigned: eeejay)
References
Details
Attachments
(1 file)
|
3.77 KB,
patch
|
yzen
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → eitan
|
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8831851 -
Flags: review?(yzenevich)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8831851 [details] [diff] [review]
Add minimumIncrement to windows ProxyAccessible. r?yzen
Review of attachment 8831851 [details] [diff] [review]:
-----------------------------------------------------------------
Not sure if important but we convert Step from double->float->double on its way from mAcc->Step() to xpcAcc->GetMinimumIncriment
copy paste nit below:
::: accessible/interfaces/gecko/IGeckoCustom.idl
@@ +12,5 @@
> {
> [propget] HRESULT ID([out, retval] unsigned __int64* aID);
> [propget] HRESULT anchorCount([out, retval] long* aCount);
> [propget] HRESULT DOMNodeID([out, retval] BSTR* aID);
> + [propget] HRESULT minimumIncrement([out, retval] float* aID);
float* aID -> float* aIncrement
Attachment #8831851 -
Flags: review?(yzenevich) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
Pushed by eisaacson@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/39fb44ee3db1
Add minimumIncrement to windows ProxyAccessible. r=yzen
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•