Closed Bug 1335220 Opened 3 years ago Closed 3 years ago

[e10s] minimumIncrement is not implemented on Windows accessible proxy.

Categories

(Core :: Disability Access APIs, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: eeejay, Assigned: eeejay)

References

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → eitan
Comment on attachment 8831851 [details] [diff] [review]
Add minimumIncrement to windows ProxyAccessible. r?yzen

Review of attachment 8831851 [details] [diff] [review]:
-----------------------------------------------------------------

Not sure if important but we convert Step from double->float->double on its way from mAcc->Step() to xpcAcc->GetMinimumIncriment
copy paste nit below:

::: accessible/interfaces/gecko/IGeckoCustom.idl
@@ +12,5 @@
>  {
>    [propget] HRESULT ID([out, retval] unsigned __int64* aID);
>    [propget] HRESULT anchorCount([out, retval] long* aCount);
>    [propget] HRESULT DOMNodeID([out, retval] BSTR* aID);
> +  [propget] HRESULT minimumIncrement([out, retval] float* aID);

float* aID -> float* aIncrement
Attachment #8831851 - Flags: review?(yzenevich) → review+
Pushed by eisaacson@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/39fb44ee3db1
Add minimumIncrement to windows ProxyAccessible. r=yzen
https://hg.mozilla.org/mozilla-central/rev/39fb44ee3db1
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.