Fix some memory leaks in jobqueue code

RESOLVED FIXED

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: dylan, Assigned: dylan)

Tracking

Production
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Clearing the request cache is not enough. We need to also call Bugzilla::Bug->CLEANUP() and the 'request_cleanup' hook
(Assignee)

Comment 1

2 years ago
We don't call _cleanup() here because it does other stuff that maybe we don't want to do...

although I realize we reconnect to the DB for every email, which is probably excessive but that can be fixed in another bug.

I would like to do more testing on this, but for the moment I see a reduction in memory usage.
Attachment #8831869 - Flags: review?(dkl)
Comment on attachment 8831869 [details] [diff] [review]
1335233_1.patch

Review of attachment 8831869 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl
Attachment #8831869 - Flags: review?(dkl) → review+
(Assignee)

Comment 3

2 years ago
To git@github.com:mozilla-bteam/bmo.git
   1cb4e01..dc47938  master -> master
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
This is now live.

dkl
(Assignee)

Updated

2 years ago
No longer blocks: 1335012
(Assignee)

Comment 5

2 years ago
we can close this if the memory usage is back to normal
You need to log in before you can comment on or make changes to this bug.