Closed Bug 1335233 Opened 5 years ago Closed 5 years ago

Fix some memory leaks in jobqueue code

Categories

(bugzilla.mozilla.org :: Administration, task)

Production
task
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: dylan, Assigned: dylan)

References

Details

Attachments

(1 file)

Clearing the request cache is not enough. We need to also call Bugzilla::Bug->CLEANUP() and the 'request_cleanup' hook
Attached patch 1335233_1.patchSplinter Review
We don't call _cleanup() here because it does other stuff that maybe we don't want to do...

although I realize we reconnect to the DB for every email, which is probably excessive but that can be fixed in another bug.

I would like to do more testing on this, but for the moment I see a reduction in memory usage.
Attachment #8831869 - Flags: review?(dkl)
Comment on attachment 8831869 [details] [diff] [review]
1335233_1.patch

Review of attachment 8831869 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl
Attachment #8831869 - Flags: review?(dkl) → review+
To git@github.com:mozilla-bteam/bmo.git
   1cb4e01..dc47938  master -> master
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
This is now live.

dkl
No longer blocks: 1335012
we can close this if the memory usage is back to normal
You need to log in before you can comment on or make changes to this bug.