Closed
Bug 1335233
Opened 9 years ago
Closed 9 years ago
Fix some memory leaks in jobqueue code
Categories
(bugzilla.mozilla.org :: Administration, task)
Tracking
()
RESOLVED
FIXED
People
(Reporter: dylan, Assigned: dylan)
References
Details
Attachments
(1 file)
|
498 bytes,
patch
|
dkl
:
review+
|
Details | Diff | Splinter Review |
Clearing the request cache is not enough. We need to also call Bugzilla::Bug->CLEANUP() and the 'request_cleanup' hook
|
Assignee | |
Comment 1•9 years ago
|
||
We don't call _cleanup() here because it does other stuff that maybe we don't want to do...
although I realize we reconnect to the DB for every email, which is probably excessive but that can be fixed in another bug.
I would like to do more testing on this, but for the moment I see a reduction in memory usage.
Attachment #8831869 -
Flags: review?(dkl)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8831869 [details] [diff] [review]
1335233_1.patch
Review of attachment 8831869 [details] [diff] [review]:
-----------------------------------------------------------------
r=dkl
Attachment #8831869 -
Flags: review?(dkl) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
To git@github.com:mozilla-bteam/bmo.git
1cb4e01..dc47938 master -> master
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
|
||
Comment 4•9 years ago
|
||
This is now live.
dkl
|
|
Assignee | |
Comment 5•9 years ago
|
||
we can close this if the memory usage is back to normal
You need to log in
before you can comment on or make changes to this bug.
Description
•