Closed
Bug 822547
Opened 13 years ago
Closed 13 years ago
jobqueue.pl should clear the request cache before sending each mail
Categories
(Bugzilla :: Email Notifications, defect)
Bugzilla
Email Notifications
Tracking
()
RESOLVED
FIXED
Bugzilla 4.4
People
(Reporter: glob, Assigned: glob)
References
Details
Attachments
(1 file)
|
1.33 KB,
patch
|
dkl
:
review+
|
Details | Diff | Splinter Review |
currently the request_cache exists for the lifetime of the jobqueue daemon. this is problematic for operations which are cached, such as adding custom fields.
we should treat each theschwartz job as a 'request', and clear the request_cache before each job is processed.
Attachment #693244 -
Flags: review?(dkl)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 693244 [details] [diff] [review]
patch v1
Review of attachment 693244 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good and works as expected. r=dkl
Attachment #693244 -
Flags: review?(dkl) → review+
|
||
Updated•13 years ago
|
Flags: approval?
Flags: approval4.4+
Flags: approval+
Target Milestone: --- → Bugzilla 4.4
Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla.pm
modified Bugzilla/JobQueue.pm
Committed revision 8540.
Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bugzilla/4.4/
modified Bugzilla.pm
modified Bugzilla/JobQueue.pm
Committed revision 8494.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
fix pod coverage bustage:
Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla.pm
modified t/011pod.t
Committed revision 8541.
You need to log in
before you can comment on or make changes to this bug.
Description
•