jobqueue.pl should clear the request cache before sending each mail

RESOLVED FIXED in Bugzilla 4.4

Status

()

Bugzilla
Email Notifications
RESOLVED FIXED
5 years ago
4 months ago

People

(Reporter: glob, Assigned: glob)

Tracking

unspecified
Bugzilla 4.4
Bug Flags:
approval +
approval4.4 +

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
currently the request_cache exists for the lifetime of the jobqueue daemon.  this is problematic for operations which are cached, such as adding custom fields.

we should treat each theschwartz job as a 'request', and clear the request_cache before each job is processed.
(Assignee)

Comment 1

5 years ago
Created attachment 693244 [details] [diff] [review]
patch v1
Attachment #693244 - Flags: review?(dkl)
Comment on attachment 693244 [details] [diff] [review]
patch v1

Review of attachment 693244 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good and works as expected. r=dkl
Attachment #693244 - Flags: review?(dkl) → review+
(Assignee)

Updated

5 years ago
Flags: approval?

Updated

5 years ago
Flags: approval?
Flags: approval4.4+
Flags: approval+
Target Milestone: --- → Bugzilla 4.4
(Assignee)

Comment 3

5 years ago
Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla.pm
modified Bugzilla/JobQueue.pm
Committed revision 8540.

Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bugzilla/4.4/
modified Bugzilla.pm
modified Bugzilla/JobQueue.pm
Committed revision 8494.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Comment 4

5 years ago
fix pod coverage bustage:

Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla.pm
modified t/011pod.t
Committed revision 8541.
Blocks: 1335233
You need to log in before you can comment on or make changes to this bug.