Closed Bug 1335348 Opened 4 years ago Closed 4 years ago

Add the UninstallServiceIfNotUsed funtion to uninstaller

Categories

(Thunderbird :: Installer, defect)

All
Windows
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 54.0

People

(Reporter: Paenglab, Assigned: Paenglab)

References

Details

Attachments

(1 file)

We should add the UninstallServiceIfNotUsed funtion to uninstaller to be sure the Maintenance Service is removed when no client is using it. This can be when only TB was installed without FX. Or when FX was uninstalled before TB.
I tested this with the try build https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=c45fdeec0ad26a9a3b9b5a62eed1c7ef8b2db9c0 on Win 8.1. Without patch the maintenance service stays installed. With patch it is removed when TB is the only client.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8832091 - Flags: review?(jorgk)
Comment on attachment 8832091 [details] [diff] [review]
uninstallFunction.patch

OK, that's copied from
M-C browser/installer/windows/nsis/uninstaller.nsi

Please remove the try line from the patch before landing it.
Attachment #8832091 - Flags: review?(jorgk) → review+
https://hg.mozilla.org/comm-central/rev/320e1e60076e8f73004fcdcac8d83dbe8e2c14a8
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 54.0
You need to log in before you can comment on or make changes to this bug.