1335349 - Allow opening a survey URL after a user chooses undo / "Don't Keep" after automatic migration of data from another browser

Status: RESOLVED FIXED

(Firefox :: Migration, defect)

Description

[:Gijs (he/him)]

Because a larger-than-expected number of people have (so far) chosen to remove the data we import, we'd like to understand the motivation of those people better in order to improve their (and everyone's!) experience. Because motivation is a qualitative issue, telemetry alone isn't enough to help guide us. We'd like to run a survey for this.

In order to do this, step 1 is having the ability to open a survey in a new (selected) tab. The survey link can be a pref, thus allowing us to enable/disable this easily. I'll also add a separate pref that checks the locale in which the user is using Firefox, as I expect we won't be able to ask the user questions in every language (and maybe just in en-US, but either way...).

Comment 1

[:Gijs (he/him)]

Attachment: Bug 1335349 - add survey link option to 'undo' for automigration,

Review commit: https://reviewboard.mozilla.org/r/108434/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/108434/

Comment 2

[:Gijs (he/him)]

Comment on attachment 8831988 [details]
Bug 1335349 - add survey link option to 'undo' for automigration,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/108434/diff/1-2/

Comment 3

[Matt Grimes [:Matt_G]]

Adding a couple folks from my team. They can create the survey content for you when you are ready. You might also want to take a look at this documentation for Survey Gizmo: https://help.surveygizmo.com/help/url-merge-codes

You can pass in additional data as URL params quite easily. Not sure if that's needed for this project, but it is available.

Comment 4

[:Gijs (he/him)]

Comment on attachment 8831988 [details]
Bug 1335349 - add survey link option to 'undo' for automigration,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/108434/diff/2-3/

Comment 5

[:Gijs (he/him)]

Comment on attachment 8831988 [details]
Bug 1335349 - add survey link option to 'undo' for automigration,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/108434/diff/3-4/

Comment 6

[Justin Dolske [:Dolske]]

Comment on attachment 8831988 [details]
Bug 1335349 - add survey link option to 'undo' for automigration,

https://reviewboard.mozilla.org/r/108434/#review111278

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9b7386fe607a
add survey link option to 'undo' for automigration, r=Dolske

Comment 8

[:Gijs (he/him)]

Comment on attachment 8831988 [details]
Bug 1335349 - add survey link option to 'undo' for automigration,

Approval Request Comment
[Feature/Bug causing the regression]: auto-migration of data from other browsers & allowing users to undo that migration
[User impact if declined]: we won't be able to ask users why they're choosing to remove the data we import
[Is this code covered by automated tests?]: yes!
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]: I don't think so. I trust the automated tests.
[List of other uplifts needed for the feature/fix]: n/a
[Is the change risky?]: no
[Why is the change risky/not risky?]: It pertains to a feature that isn't enabled for release, and even when that feature is enabled (x-ref bug 1335709), this patch only does something when a further preference is set to a relevant survey URL. So this shouldn't affect release at all.
[String changes made/needed]: nope

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9b7386fe607a

Comment 10

[Julien Cristau [:jcristau]]

Comment on attachment 8831988 [details]
Bug 1335349 - add survey link option to 'undo' for automigration,

automigration experiment work, aurora53+ / beta52+

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/468bfd99fb22

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/9c1abdef23a8

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr52/rev/9c1abdef23a8