1335360 - Highlighted word has no space after stylized characters

Status: ASSIGNED

(Toolkit :: Find Toolbar, defect)

Description

[Timea Zsoldos [:zstimi/tzsoldos], Desktop Release QA]

[Affected versions]:
-Firefox 54.0a1

[Affected platforms]:
-Win 8.1 x64
-Ubuntu 16.04 x64
-Mac OS X 10.11

[Steps to reproduce]:
1. Launch Firefox.
2. Open link from additional notes.
3. Search for "test case" using "Ctrl"/"CMD" + "F"(without quote).

[Expected result]:
-The search highlights "test case" with the space between the words.

[Actual result]:
-The search highlights "test case" without the space between the words.

[Regression range]:

 Last good: 20161013030204
 First bad: 20161014060324
 Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=644b3de5d7a18b101d44a003bc27d50853dee4c9&tochange=a07fb64ae0a7dc76aa0f8e7067ed169baf11ef7c

[Additional notes]:
-Link for testing: https://bugzilla.mozilla.org/attachment.cgi?id=8762295
-Similar issue: https://bugzilla.mozilla.org/show_bug.cgi?id=1279704

Comment 1

[David Bolter [:davidb] (NeedInfo me for attention)]

Is this a possible regression from bug 1283042?

Comment 2

[Mike de Boer [:mikedeboer]]

Highly unlikely. It's more likely to be caused by bradwerth's work on platform APIs helping the modal highlighting feature.

Brad, do you think your recent fixes also fixed this bug possibly?

Comment 3

[Brad Werth [:bradwerth]]

Nothing I've landed would have fixed this. I noted the same issue in Bug 1340731. The caller of getClientRectsAndText seems to strip leading whitespace before drawing the highlight text.

Comment 4

[Mike de Boer [:mikedeboer]]

OK, thanks Brad. I will check out what we're doing wrong.

Comment 5

[Nathan Froyd [:froydnj]]

This is for the new find toolbar, correct?  So our shipping releases are not actually affected by this bug, correct?

Comment 6

[Mike de Boer [:mikedeboer]]

(In reply to Nathan Froyd [:froydnj] from comment #5)
> This is for the new find toolbar, correct?  So our shipping releases are not
> actually affected by this bug, correct?

Indeed.

Comment 7

[Nathan Froyd [:froydnj]]

Another release, another twiddling of flags.

Comment 8

[Mike Taylor [:miketaylr]]

AFAICT, we're not shipping this yet. Setting to disabled for all current versions.