1335536 - File.createFromNsIFile and File.createFromFileName should be async

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Andrea Marchesini [:baku]]

These 2 methods are chome only and mainly used for testing. They should be async.

Comment 1

[Andrea Marchesini [:baku]]

Attachment: part 1 - Async tests

Comment 2

[Andrea Marchesini [:baku]]

Attachment: part 2 - async File::CreateFromNsIFile/CreateFromFileName

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/99587cc6ef23
File.createFromNsIFile and File.createFromFileName should be async - part 1 - tests, r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/2ad6a2821772
File.createFromNsIFile and File.createFromFileName should be async - part 2 - code, r=smaug

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for failing robocop testFilePicker on Android:

https://hg.mozilla.org/integration/mozilla-inbound/rev/d6fbd222e21a6fcfc08a70005aec10dde8fed9e9
https://hg.mozilla.org/integration/mozilla-inbound/rev/d6fbd222e21a6fcfc08a70005aec10dde8fed9e9

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=2ad6a28217722afd332f9194eabaa31c83b368b0
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=73589595&repo=mozilla-inbound

[task 2017-02-01T17:13:03.788556Z] 17:13:03  WARNING -  TEST-UNEXPECTED-FAIL | testFilePicker | GeckoEventExpecter - blockForEvent timeout: Robocop:Java
[task 2017-02-01T17:13:03.788805Z] 17:13:03     INFO -  EventExpecter: no longer listening for Robocop:Java
[task 2017-02-01T17:13:03.788984Z] 17:13:03     INFO -  Unregistered listener for Robocop:Java
[task 2017-02-01T17:13:03.789256Z] 17:13:03     INFO -  0 ERROR Exception caught during test! - junit.framework.AssertionFailedError: TEST-UNEXPECTED-FAIL | testFilePicker | GeckoEventExpecter - blockForEvent timeout: Robocop:Java
[task 2017-02-01T17:13:03.789416Z] 17:13:03     INFO -  	at junit.framework.Assert.fail(Assert.java:50)
[task 2017-02-01T17:13:03.789637Z] 17:13:03     INFO -  	at org.mozilla.gecko.FennecMochitestAssert._logMochitestResult(FennecMochitestAssert.java:124)
[task 2017-02-01T17:13:03.789828Z] 17:13:03     INFO -  	at org.mozilla.gecko.FennecMochitestAssert.ok(FennecMochitestAssert.java:145)
[task 2017-02-01T17:13:03.790039Z] 17:13:03     INFO -  	at org.mozilla.gecko.FennecNativeActions$GeckoEventExpecter.blockForEvent(FennecNativeActions.java:135)
[task 2017-02-01T17:13:03.790286Z] 17:13:03     INFO -  	at org.mozilla.gecko.FennecNativeActions$GeckoEventExpecter.blockForEvent(FennecNativeActions.java:119)
[task 2017-02-01T17:13:03.790466Z] 17:13:03     INFO -  	at org.mozilla.gecko.FennecNativeActions$GeckoEventExpecter.blockForBundle(FennecNativeActions.java:193)
[task 2017-02-01T17:13:03.790662Z] 17:13:03     INFO -  	at org.mozilla.gecko.tests.JavascriptTest.doTestJavascript(JavascriptTest.java:62)
[task 2017-02-01T17:13:03.790885Z] 17:13:03     INFO -  	at org.mozilla.gecko.tests.JavascriptTest.testJavascript(JavascriptTest.java:40)
[task 2017-02-01T17:13:03.791076Z] 17:13:03     INFO -  	at java.lang.reflect.Method.invokeNative(Native Method)
[task 2017-02-01T17:13:03.791267Z] 17:13:03     INFO -  	at java.lang.reflect.Method.invoke(Method.java:525)
[task 2017-02-01T17:13:03.791478Z] 17:13:03     INFO -  	at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
[task 2017-02-01T17:13:03.791681Z] 17:13:03     INFO -  	at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
[task 2017-02-01T17:13:03.791923Z] 17:13:03     INFO -  	at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
[task 2017-02-01T17:13:03.792114Z] 17:13:03     INFO -  	at org.mozilla.gecko.tests.BaseRobocopTest.runTest(BaseRobocopTest.java:188)
[task 2017-02-01T17:13:03.792298Z] 17:13:03     INFO -  	at junit.framework.TestCase.runBare(TestCase.java:134)
[task 2017-02-01T17:13:03.792492Z] 17:13:03     INFO -  	at junit.framework.TestResult$1.protect(TestResult.java:115)
[task 2017-02-01T17:13:03.792688Z] 17:13:03     INFO -  	at junit.framework.TestResult.runProtected(TestResult.java:133)
[task 2017-02-01T17:13:03.792874Z] 17:13:03     INFO -  	at junit.framework.TestResult.run(TestResult.java:118)
[task 2017-02-01T17:13:03.793059Z] 17:13:03     INFO -  	at junit.framework.TestCase.run(TestCase.java:124)
[task 2017-02-01T17:13:03.793257Z] 17:13:03     INFO -  	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
[task 2017-02-01T17:13:03.793452Z] 17:13:03     INFO -  	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
[task 2017-02-01T17:13:03.793676Z] 17:13:03     INFO -  	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554)
[task 2017-02-01T17:13:03.793883Z] 17:13:03     INFO -  	at org.mozilla.gecko.FennecInstrumentationTestRunner.onStart(FennecInstrumentationTestRunner.java:64)
[task 2017-02-01T17:13:03.794090Z] 17:13:03     INFO -  	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)
[task 2017-02-01T17:13:03.794352Z] 17:13:03  WARNING -  TEST-UNEXPECTED-FAIL | testFilePicker | Exception caught - junit.framework.AssertionFailedError: TEST-UNEXPECTED-FAIL | testFilePicker | GeckoEventExpecter - blockForEvent timeout: Robocop:Java

Comment 5

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/209dd2a63640
Backed out changeset 2ad6a2821772

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b6a45e1bab4c
File.createFromNsIFile and File.createFromFileName should be async - part 1 - tests, r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/2c0af863f3e8
File.createFromNsIFile and File.createFromFileName should be async - part 2 - code, r=smaug

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b6a45e1bab4c
https://hg.mozilla.org/mozilla-central/rev/2c0af863f3e8