1335607 - ClearOnShutdown_Internal::sCurrentShutdownPhase is never modified

Status: RESOLVED DUPLICATE of bug 1663747

(Core :: XPCOM, defect, P3)

Description

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

I don't see any code that sets or modifies the value of ClearOnShutdown_Internal::sCurrentShutdownPhase, besides the NotInShutdown initializer.

Just in case I was missing something, I tried attaching a gdb watchpoint to the variable and then quitting Firefox; it exited without triggering the watchpoint.  A read watchpoint showed ClearOnShutdown and KillClearOnShutdown reading it, to check that a given shutdown phase hadn't been reached yet, but the value read was always NotInShutdown, even as the phase argument passed to KillClearOnShutdown increased.

Comment 1

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

I took a stab at this (because I was looking at ClearOnShutdown for other reasons and remembered this bug) and broke xpcshell tests because apparently they load string bundles during shutdown: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3f73b6949af2f17f1a8a61e2986ff421f730af69

Comment 2

[Andrew McCreight [:mccr8]]

There's some investigation of this issue in bug 1492629 comment 23. The gist of it is that the loading of locale means that we need an extra round of KillClearOnShutdown, that has no other use right now.

Comment 3

[Andrew McCreight [:mccr8]]

Doug, this may be of interest to you if you are looking at XPCOM shutdown stuff. I'm not sure if it is actually relevant or not.