Closed Bug 1335607 Opened 8 years ago Closed 4 years ago

ClearOnShutdown_Internal::sCurrentShutdownPhase is never modified

Categories

(Core :: XPCOM, defect, P3)

Product:
Core
Component:
XPCOM
Type:
defect

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1663747
Tracking Flags:
Tracking Status
firefox54 --- affected

People

(Reporter: jld, Unassigned)

References

(Blocks 1 open bug)

Details

I don't see any code that sets or modifies the value of ClearOnShutdown_Internal::sCurrentShutdownPhase, besides the NotInShutdown initializer. Just in case I was missing something, I tried attaching a gdb watchpoint to the variable and then quitting Firefox; it exited without triggering the watchpoint. A read watchpoint showed ClearOnShutdown and KillClearOnShutdown reading it, to check that a given shutdown phase hadn't been reached yet, but the value read was always NotInShutdown, even as the phase argument passed to KillClearOnShutdown increased.
Priority: -- → P3
I took a stab at this (because I was looking at ClearOnShutdown for other reasons and remembered this bug) and broke xpcshell tests because apparently they load string bundles during shutdown: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3f73b6949af2f17f1a8a61e2986ff421f730af69

There's some investigation of this issue in bug 1492629 comment 23. The gist of it is that the loading of locale means that we need an extra round of KillClearOnShutdown, that has no other use right now.

Depends on: 1528412

Doug, this may be of interest to you if you are looking at XPCOM shutdown stuff. I'm not sure if it is actually relevant or not.

Flags: needinfo?(dothayer)
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → DUPLICATE
Flags: needinfo?(dothayer)
You need to log in before you can comment on or make changes to this bug.