1663747 - Fix ClearOnShutdown's sCurrentShutdownPhase and add API to compare against it

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement)

Description

[Kris Maglione [:kmag]]

This would be useful for the many callers which want to bail out early when it's too late in shutdown. Particularly after ClearOnShutdown has already run on a pointer that they're considering initializing.

Comment 3

[Kris Maglione [:kmag]]

Attachment: Bug 1663747: Part 1 - Fix sCurrentShutdownPhase and add PastShutdownPhase() API. r=nika

Comment 4

[Kris Maglione [:kmag]]

Attachment: Bug 1663747: Part 2 - Use PastShutdownPhase() in component loader shutdown checks. r=mccr8

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/491472fe44f4
Part 1 - Fix sCurrentShutdownPhase and add PastShutdownPhase() API. r=nika
https://hg.mozilla.org/integration/autoland/rev/643aa6baf458
Part 2 - Use PastShutdownPhase() in component loader shutdown checks. r=mccr8

Comment 6

[Alexandru Michis [:malexandru]]

Backed out 2 changesets (Bug 1663747) for causing xpcshell failures in ThrottledEventQueue.

Backout link: https://hg.mozilla.org/integration/autoland/rev/0beae55ee1b5d6f06d9d568c65a80fb1d79373a9

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&searchStr=windows%2C7%2Cdebug%2Cxpcshell%2Ctests%2Ctest-windows7-32%2Fdebug-xpcshell-e10s%2Cx1&tochange=c8ad715374b3f442cba2df19c9664f000a5040c9&fromchange=bd174309203d44991ab64f5ff1dbe95b495be0f8

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=316319145&repo=autoland&lineNumber=9028

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c5beb9ff8f8d
Part 1 - Fix sCurrentShutdownPhase and add PastShutdownPhase() API. r=nika
https://hg.mozilla.org/integration/autoland/rev/65c4daebb7a7
Part 2 - Use PastShutdownPhase() in component loader shutdown checks. r=mccr8

Comment 8

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/c5beb9ff8f8d
https://hg.mozilla.org/mozilla-central/rev/65c4daebb7a7