1336004 - build error in Sampler.cpp after enable Task Tracer

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect)

Description

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

>In file included from mozilla-central/obj-firefox/tools/profiler/Unified_cpp_tools_profiler0.cpp:47:0:
>mozilla-central/tools/profiler/core/Sampler.cpp: In constructor 'Sampler::Sampler(double, int, const char**, uint32_t, const char**, uint32_t)':
>mozilla-central/tools/profiler/core/Sampler.cpp:234:14: error: 'mozilla::tasktracer' has not been declared
>In file included from mozilla-central/obj-firefox/tools/profiler/Unified_cpp_tools_profiler0.cpp:47:0:
>mozilla-central/tools/profiler/core/Sampler.cpp: In destructor 'Sampler::~Sampler()':
>mozilla-central/tools/profiler/core/Sampler.cpp:270:14: error: 'mozilla::tasktracer' has not been declared
>In file included from mozilla-central/obj-firefox/tools/profiler/Unified_cpp_tools_profiler0.cpp:47:0:
>mozilla-central/tools/profiler/core/Sampler.cpp: In member function 'void Sampler::StreamTaskTracer(SpliceableJSONWriter&)':
>mozilla-central/tools/profiler/core/Sampler.cpp:403:52: error: 'mozilla::tasktracer' has not been declared
>mozilla-central/tools/profiler/core/Sampler.cpp:426:64: error: 'mozilla::tasktracer' has not been declared

Comment 1

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Attachment: Bug 1336004 - add missing header file for TaskTracer.

Review commit: https://reviewboard.mozilla.org/r/109058/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/109058/

Comment 2

[Cervantes Yu [:cyu] [:cervantes]]

Comment on attachment 8832778 [details]
Bug 1336004 - add missing header file for TaskTracer.

https://reviewboard.mozilla.org/r/109058/#review110252

Thanks for the fix.

Comment 3

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=985dedf30f46

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0252f79c9a2a
add missing header file for TaskTracer. r=cyu

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0252f79c9a2a