133610 - Revert to using attribute for menuactive state

Status: VERIFIED FIXED

(Core :: XUL, defect)

Description

[Brian Ryner (not reading)]

Due to unexpected problems with any of the (now 3) implementations of
:-moz-menuactive that we've tried, we should back out this change and go back to
using an attribute, given the impending 1.0 release.  We can use _moz-menuactive
to hide the attribute from DOM serialization.

Comment 1

[Brian Ryner (not reading)]

Attachment: patch

Comment 2

[Brian Ryner (not reading)]

Attachment: same patch, with call site in accessible/ corrected

Comment 3

[Johnny Stenback (:jst)]

Comment on attachment 76295 [details] [diff] [review]
same patch, with call site in accessible/ corrected

sr=jst

Comment 4

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 76295 [details] [diff] [review]
same patch, with call site in accessible/ corrected

r=[e-mail]

Comment 5

[Brian Ryner (not reading)]

Attachment: patch for nsHTMLOptGroupElement and nsHTMLSelectElement

I forgot to remove the nsIMenuElement implementation.

Comment 6

[Brian Ryner (not reading)]

Comment on attachment 76319 [details] [diff] [review]
patch for nsHTMLOptGroupElement and nsHTMLSelectElement

sr=jst via irc

Comment 7

[John Keiser (jkeiser)]

Comment on attachment 76319 [details] [diff] [review]
patch for nsHTMLOptGroupElement and nsHTMLSelectElement

r=jkeiser

Comment 8

[Asa Dotzler [:asa]]

Comment on attachment 76319 [details] [diff] [review]
patch for nsHTMLOptGroupElement and nsHTMLSelectElement

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 9

[Brian Ryner (not reading)]

checked in.

Comment 10

[shrirang khanzode]

.