1336272 - Replace uses of resultset/result-set/result_set with "push"

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P3)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Bug 1184510 changed the user-facing strings from "resultset" to "push". The same arguments made in that bug could apply to the backend and supporting code.

Comment 1

[William Lachance (:wlach)]

We would have to be careful doing this so as not to break the API (i.e. we would either need to use versioning on the existing endpoints or add new ones which don't use the "result set" nomenclature). Not sure if it's worth the effort tbh.

Comment 2

[Cameron Dawson [:camd]]

Some of this work could just be changing classnames and function names used only internally.  As Will said, for apis, we may just want to add new "push" versions alongside the resultset versions.  Versioning the API at some point might be nice as well.

Comment 3

[GitHub Autolander Bot]

Attachment: [treeherder] maxchehab:master > mozilla:master

Comment 4

[Cameron Dawson [:camd]]

Max's first PR will change from resultset/result_set to push on the internal python code.  Later PRs can address:

queue names for our own rabbit mq
queue names for Pulse queues
Remove old API endpoints
Change API parameter names to push
UI (JS, CSS and HTML, etc)

Comment 5

[Cameron Dawson [:camd]]

prior to merging we will have to add the new (changed) env var to all the environments:

PULSE_PUSH_SOURCES

Once this is pushed to production, and everything is restarted, we can remove the old ``PUSH_RESULTSET_SOURCES``

Comment 6

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/c6e0c26bc8f0adc1490de7c7f130d35ab892e3be
Bug 1336272 - Refactor changing wording from resultset to push (#2644)

Change of new environment variable `PULSE_PUSH_SOURCES`.

Keep old `publish-resultset-runnable-job-action` task name by creating a 
method that points to `publish_push_runnable_job_action`.

Comment 7

[Cameron Dawson [:camd]]

Thanks for this PR Max!  Nice work!  We can move on to some of the other parts of this when you're ready.  But this was a huge step in the right direction.  The next parts will be queue names, which will require having both queues for a short time, then removing the old ones in a separate PR when they're drained.  

Congrats on getting your first PR merged.  :)

Comment 8

[Ed Morley [:emorley]]

I've deployed this to production and set the new `worker_read_pulse_pushes` dyno name to 1.

Nest steps:
* Removing the old `PULSE_RESULTSET_SOURCES` environment variables from prototype/stage/prod (I'll do this using the Heroku CLI now)
* Releasing a new treeherder-client version to PyPI that uses the new /push/ API endpoint and includes the deprecated warning for the old client method name. I'll file a new bug for this part
* Performing the next round of changes in the Treeherder repo

The parts that will need to be left for longer are:
* The old /resultset/ API endpoint
* Any API responses that use the property names like `result_set_id` (I guess we'll have to have both old and new fields for a whole)
* The treeherder-client deprecation warning

Comment 9

[Ed Morley [:emorley]]

(In reply to Ed Morley [:emorley] from comment #8)
> * Removing the old `PULSE_RESULTSET_SOURCES` environment variables

Done.

Comment 10

[Ed Morley [:emorley]]

I'll file a new bug for the remaining work :-)