1336287 - [webvr] Checking OpenVR system before HandleInput()

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Daosheng Mu[:daoshengmu]]

Because we always would create and initialize VR system manager when we make 'dom.vr.openvr.enabled' to be true, after Bug 1332989, the mechanism of our system manager for controllers needs to check if mVRSystem has already been set before updating VR controllers.

Comment 1

[Daosheng Mu[:daoshengmu]]

VRDisplay always uses displayId that is generated at GetHMDs() to call mVRSystem to update. Therefore, VRDisplay can make sure the mVRSystem has already been created but for controllers we can not.

Comment 2

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1336287 - Checking OpenVR system is not null before HandleInput();

Review commit: https://reviewboard.mozilla.org/r/109402/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/109402/

Comment 3

[:kip (Kearwood Gilbert)]

Comment on attachment 8833175 [details]
Bug 1336287 - Checking OpenVR system is not null before HandleInput();

https://reviewboard.mozilla.org/r/109402/#review110704

Thanks!  LGTM

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/integration/autoland/rev/35a6ec627a8dfe4d8106135a5607ffda86c4a3ce

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/35a6ec627a8d