Closed Bug 1336373 Opened 3 years ago Closed 3 years ago

Custom tabs: Action button icon supports tint

Categories

(Firefox for Android :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 55
Tracking Status
firefox55 --- fixed

People

(Reporter: walkingice, Assigned: walkingice)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

When creating CustomTabsIntent, developer could also set `shouldTint` to true in `CustomTabsIntent.Builder.setActionButton`. CustomTabsActivity's Action Button should support it.
Comment on attachment 8849508 [details]
Bug 1336373 - CustomTabsActivity supports tint in Action Button

https://reviewboard.mozilla.org/r/122306/#review124400
Attachment #8849508 - Flags: review?(s.kaspari) → review+
In testCustomTabsActivity it throws a NPE. Therefore I changed interface of method `CustomTabsActivity.insertActionButton`. Rather than accessing `actionPresenter` in that method, I think pass color as parameter would keep that method more clean.
Keywords: checkin-needed
Pushed by ihsiao@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8a8b318fc4e9
CustomTabsActivity supports tint in Action Button r=sebastian
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/8a8b318fc4e9
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
You need to log in before you can comment on or make changes to this bug.