Closed
Bug 1336373
Opened 7 years ago
Closed 7 years ago
Custom tabs: Action button icon supports tint
Categories
(Firefox for Android Graveyard :: General, defect)
Firefox for Android Graveyard
General
Tracking
(firefox55 fixed)
RESOLVED
FIXED
Firefox 55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: walkingice, Assigned: walkingice)
References
Details
Attachments
(1 file)
When creating CustomTabsIntent, developer could also set `shouldTint` to true in `CustomTabsIntent.Builder.setActionButton`. CustomTabsActivity's Action Button should support it.
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8849508 [details] Bug 1336373 - CustomTabsActivity supports tint in Action Button https://reviewboard.mozilla.org/r/122306/#review124400
Attachment #8849508 -
Flags: review?(s.kaspari) → review+
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 5•7 years ago
|
||
In testCustomTabsActivity it throws a NPE. Therefore I changed interface of method `CustomTabsActivity.insertActionButton`. Rather than accessing `actionPresenter` in that method, I think pass color as parameter would keep that method more clean.
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ihsiao@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8a8b318fc4e9 CustomTabsActivity supports tint in Action Button r=sebastian
Keywords: checkin-needed
Comment 7•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8a8b318fc4e9
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•