1336373 - Custom tabs: Action button icon supports tint

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Julian Chu [:walkingice]]

When creating CustomTabsIntent, developer could also set `shouldTint` to true in `CustomTabsIntent.Builder.setActionButton`. CustomTabsActivity's Action Button should support it.

Comment 1

[Julian Chu [:walkingice]]

Attachment: Bug 1336373 - CustomTabsActivity supports tint in Action Button

If 3-rd party app specify to use tint for Action Button, use primary
text color as the tint color for Action Button.

Review commit: https://reviewboard.mozilla.org/r/122306/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/122306/

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8849508 [details]
Bug 1336373 - CustomTabsActivity supports tint in Action Button

https://reviewboard.mozilla.org/r/122306/#review124400

Comment 3

[Julian Chu [:walkingice]]

Comment on attachment 8849508 [details]
Bug 1336373 - CustomTabsActivity supports tint in Action Button

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/122306/diff/1-2/

Comment 4

[Julian Chu [:walkingice]]

Comment on attachment 8849508 [details]
Bug 1336373 - CustomTabsActivity supports tint in Action Button

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/122306/diff/2-3/

Comment 5

[Julian Chu [:walkingice]]

In testCustomTabsActivity it throws a NPE. Therefore I changed interface of method `CustomTabsActivity.insertActionButton`. Rather than accessing `actionPresenter` in that method, I think pass color as parameter would keep that method more clean.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8a8b318fc4e9
CustomTabsActivity supports tint in Action Button r=sebastian

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8a8b318fc4e9