Closed Bug 1336373 Opened 5 years ago Closed 5 years ago
Custom tabs: Action button icon supports tint
59 bytes, text/x-review-board-request
When creating CustomTabsIntent, developer could also set `shouldTint` to true in `CustomTabsIntent.Builder.setActionButton`. CustomTabsActivity's Action Button should support it.
Comment on attachment 8849508 [details] Bug 1336373 - CustomTabsActivity supports tint in Action Button https://reviewboard.mozilla.org/r/122306/#review124400
Attachment #8849508 - Flags: review?(s.kaspari) → review+
In testCustomTabsActivity it throws a NPE. Therefore I changed interface of method `CustomTabsActivity.insertActionButton`. Rather than accessing `actionPresenter` in that method, I think pass color as parameter would keep that method more clean.
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/8a8b318fc4e9 CustomTabsActivity supports tint in Action Button r=sebastian
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.