1329144 - Custom tabs: support custom action button

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Joe Cheng [:jcheng] (please needinfo)]

as a 3rd party app developer, I want to be able to customize the action button when I make use of custom tabs

Comment 1

[Julian Chu [:walkingice]]

Attachment: Bug 1329144 - Remove useless variable

This variable is useless. So far we reference to a toolbar instance by
local variable. Removing it makes less ambiguous.

Review commit: https://reviewboard.mozilla.org/r/109986/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/109986/

Comment 2

[Julian Chu [:walkingice]]

Attachment: Bug 1329144 - IntentUtil can extract ActionButton info from Intent

To support ActionButton in CustomTabsActivity, information should be
extract from intent.

Review commit: https://reviewboard.mozilla.org/r/109988/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/109988/

Comment 3

[Julian Chu [:walkingice]]

Attachment: Bug 1329144 - CustomTabsActivity supports ActionButton

3rd-party-app could launch CustomTabsActivity, and could also configure
a custom action button. Now let CustomTabsActivity supports it by
creating a MenuItem.

Review commit: https://reviewboard.mozilla.org/r/109990/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/109990/

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8833876 [details]
Bug 1329144 - Remove useless variable

https://reviewboard.mozilla.org/r/109986/#review111550

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8833877 [details]
Bug 1329144 - IntentUtil can extract ActionButton info from Intent

https://reviewboard.mozilla.org/r/109988/#review111552

Comment 6

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8833878 [details]
Bug 1329144 - CustomTabsActivity supports ActionButton

https://reviewboard.mozilla.org/r/109990/#review111554

::: mobile/android/base/java/org/mozilla/gecko/customtabs/CustomTabsActivity.java:278
(Diff revision 1)
> +    private void onActionButtonClicked() {
> +        PendingIntent pendingIntent = IntentUtil.getActionButtonPendingIntent(getIntent());
> +        try {
> +            pendingIntent.send();
> +        } catch (Exception e) {
> +            e.printStackTrace();

Let's use an explicit log statement.

Comment 7

[Julian Chu [:walkingice]]

Comment on attachment 8833878 [details]
Bug 1329144 - CustomTabsActivity supports ActionButton

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/109990/diff/1-2/

Comment 8

[Julian Chu [:walkingice]]

Comment on attachment 8833878 [details]
Bug 1329144 - CustomTabsActivity supports ActionButton

https://reviewboard.mozilla.org/r/109990/#review111554

> Let's use an explicit log statement.

OK! Log.w should be enough here.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/13520d439d2e
Remove useless variable r=sebastian
https://hg.mozilla.org/integration/autoland/rev/e474c788d36a
IntentUtil can extract ActionButton info from Intent r=sebastian
https://hg.mozilla.org/integration/autoland/rev/eac05c94053a
CustomTabsActivity supports ActionButton r=sebastian

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/13520d439d2e
https://hg.mozilla.org/mozilla-central/rev/e474c788d36a
https://hg.mozilla.org/mozilla-central/rev/eac05c94053a

Comment 11

[Sorina Florean [:sflorean]]

Tested on Google+, News&Weather, Chromer and tapping on custom button display results.
Verified as fixed in build 55.0a1 (2017-05-17) with devices: HTC Desire 820 (Android 6.0.1) and Nexus 9 (Android 7.1.1).