Closed Bug 1336905 Opened 3 years ago Closed 3 years ago

Replace StyleShapeOutsideShapeBox by StyleGeometryBox

Categories

(Core :: Layout, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: u459114, Assigned: u459114)

References

Details

Attachments

(2 files)

Simply because StyleGeometryBox contains all box values need by StyleShapeOutsideShapeBox, and we can remove many template function after this change.
Transform-box will use StyleGeometryBox after we land bug 1335876:
https://reviewboard.mozilla.org/r/109020/diff/3#index_header
Attachment #8833885 - Flags: review?(tlin)
Attachment #8833886 - Flags: review?(tlin)
Comment on attachment 8833885 [details]
Bug 1336905 - Part 1. Remove StyleShapeSource's template argument.

https://reviewboard.mozilla.org/r/109998/#review111014
Attachment #8833885 - Flags: review?(tlin) → review+
Comment on attachment 8833886 [details]
Bug 1336905 - Part 2. Remove StyleShapeOutsideShapeBox.

https://reviewboard.mozilla.org/r/110000/#review111016
Attachment #8833886 - Flags: review?(tlin) → review+
Part 1 touches servo binding. CC heycam in case that something need to be done on stylo.
Attachment #8833885 - Flags: review?(cam)
Comment on attachment 8833885 [details]
Bug 1336905 - Part 1. Remove StyleShapeSource's template argument.

https://reviewboard.mozilla.org/r/109998/#review113546

r=me on the ServoBindings.{h,cpp} changes.  The Servo side will need to change once this lands, but I'll get someone to handle that.
Attachment #8833885 - Flags: review?(cam) → review+
Pushed by cku@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fb3c04effbd1
Part 1. Remove StyleShapeSource's template argument. r=heycam,TYLin
https://hg.mozilla.org/integration/autoland/rev/f76fbaee4ce8
Part 2. Remove StyleShapeOutsideShapeBox. r=TYLin
backed out for bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=77050609&repo=autoland in coordinaton with c.j and heycam
Flags: needinfo?(cku)
Backout by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/67937aaaac25
Backed out changeset f76fbaee4ce8 
https://hg.mozilla.org/integration/autoland/rev/cb86d9e08672
Backed out changeset fb3c04effbd1 for bustage in stylo builds
CJ, I landed bug 1326407 to inbound, and it will conflict with your patch. I'm sorry that you'll need to rebase.
Pushed by manishearth@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/124fbb4b9a97
Part 1. Remove StyleShapeSource's template argument. r=heycam,TYLin
https://hg.mozilla.org/integration/autoland/rev/fc3485436aa5
Part 2. Remove StyleShapeOutsideShapeBox. r=TYLin
https://hg.mozilla.org/mozilla-central/rev/124fbb4b9a97
https://hg.mozilla.org/mozilla-central/rev/fc3485436aa5
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Flags: needinfo?(cku)
Depends on: 1437599
You need to log in before you can comment on or make changes to this bug.