6.24 KB, patch
|Details | Diff | Splinter Review|
59.50 KB, image/jpeg
Companion to bug 1305969 - occasionally Fennec gets into a state where there is a permanent white space the size of the toolbar immediately *below* the toolbar. > 4 Feb 2017 > 10:11 gcp Nightly is busted? > 10:11 gcp I have a bar the size of the awesomebar above all content' I've seen this myself recently, although I can't say for sure whether only on Nightly/local builds or on Release as well.
Likely we won't investigate this until bug 1335895 is done.
Depends on: 1335895
Priority: -- → P3
Version: unspecified → 54 Branch
Found some hopefully easy and reliable STR: 1. Cold start Firefox. 2. As soon as the UI becomes visible, press the Home button to background it again. 3. Wait a bit to give Gecko time to start up. 4. Bring Firefox into the foreground again. There should now be a permanent bit of white space below the toolbar. After the next background/foreground cycle, this issue will fix itself. If it helps narrowing things down, I can't reproduce this in 50.
Has STR: --- → yes
(In reply to Jan Henning [:JanH] from comment #2) > If it helps narrowing things down, I can't reproduce this in 50. If this is a regression then we should probably track down a regression range to avoid shipping it.
status-firefox54: --- → affected
Keywords: regression, regressionwindow-wanted
Regressing push: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=8aa58e6577516d8bde4ff9d4555e59d6a511fc4f&filter-searchStr=android%20api%2015%20opt
Has Regression Range: --- → yes
status-firefox51: --- → unaffected
status-firefox52: --- → unaffected
status-firefox53: --- → affected
[Tracking Requested - why for this release]: Regression in Fx 53
tracking-fennec: --- → ?
tracking-firefox53: --- → ?
tracking-firefox54: --- → ?
My guess is that a re-paint is failing after a resize. Just rotating device and rotating back fixes the issue. I can reproduce the issue. One change that I made in Bug 1328752 is always requesting the repaint from the UI thread instead of requesting it from both UI and main thread which IPC/IPDL doesn't like. I'll look there first.
The SyncResumeResizeCompositor is failing because the UiCompositorControllerChild hasn't established its connection with the compositor thread yet so its a race condition. Looking into possible solutions now.
Created attachment 8834651 [details] [diff] [review] 0001-Bug-1336929-Have-UiCompositorControllerChild-cache-surface-resize-when-not-yet-initialized-17020714-57d6624e.patch
Created attachment 8834675 [details] [diff] [review] 0001-Bug-1336929-Have-UiCompositorControllerChild-cache-surface-resize-when-not-yet-initialized-17020715-cc182a0.patch
Attachment #8834651 - Attachment is obsolete: true
Attachment #8834675 - Flags: review?(nchen) → review+
Created attachment 8835580 [details] photo5539583883226490793.jpg ¡Hola Randall! Is the bug pictured in the attachment this bug? In my case, the height of the white space is a bit larger than the awesome bar. Also taps on the screen seem to be miss interpreted by about the same amount of space. ¡Gracias! Alex
(In reply to alex_mayorga from comment #11) > Created attachment 8835580 [details] > photo5539583883226490793.jpg > > ¡Hola Randall! > > Is the bug pictured in the attachment this bug? > > In my case, the height of the white space is a bit larger than the awesome > bar. > > Also taps on the screen seem to be miss interpreted by about the same amount > of space. > > ¡Gracias! > Alex This is probably the same bug. The size of the white space has nothing to do with size of the awesome bar but instead what ever size the compositor was initialized with.
Tracking 53/54+ for this visible regression.
tracking-firefox53: ? → +
tracking-firefox54: ? → +
Attachment #8834675 - Flags: review?(dvander) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/6f43298f5271 Have UiCompositorControllerChild cache surface resize when not yet initialized. r=jchen,dvander
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox54: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
Please request Aurora approval on this when you get a chance.
I can no longer reproduce this on a local build based on the current mozilla-central as well as today's Nightly.
Status: RESOLVED → VERIFIED
No longer blocks: 1338811
Duplicate of this bug: 1338811
Comment on attachment 8834675 [details] [diff] [review] 0001-Bug-1336929-Have-UiCompositorControllerChild-cache-surface-resize-when-not-yet-initialized-17020715-cc182a0.patch Approval Request Comment [Feature/Bug causing the regression]:Bug 1328752 [User impact if declined]: The page content will sometimes be shifted down causing a white bar across the top of the content page and touch events will not align with content. [Is this code covered by automated tests?]: No. [Has the fix been verified in Nightly?]: Yes [Needs manual test from QE? If yes, steps to reproduce]: No. [List of other uplifts needed for the feature/fix]: None. [Is the change risky?]: No [Why is the change risky/not risky?]: It just adds a simple cache for when the class is not initialized yet. [String changes made/needed]: None
Attachment #8834675 - Flags: approval-mozilla-aurora?
Comment on attachment 8834675 [details] [diff] [review] 0001-Bug-1336929-Have-UiCompositorControllerChild-cache-surface-resize-when-not-yet-initialized-17020715-cc182a0.patch Fix a UI issue that a white bar below the toolbar. Aurora53+.
Attachment #8834675 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
status-firefox53: affected → fixed
You need to log in before you can comment on or make changes to this bug.