1336934 - Allow to remove all session cookies of a website

Status: RESOLVED FIXED

(DevTools :: Storage Inspector, enhancement, P3)

Description

[Sebastian Zartner [:sebo]]

The context menu within the cookies section of the Storage Inspector should provide an option to only delete session cookies like Firebug did it.

Sebastian

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Filter on HOTFROG.

Comment 2

[Sebastian Zartner [:sebo]]

Attachment: Bug 1336934 - Added option to remove all session cookies for a specific domain

Review commit: https://reviewboard.mozilla.org/r/172590/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/172590/

Comment 3

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8901105 [details]
Bug 1336934 - Added option to remove all session cookies for a specific domain

https://reviewboard.mozilla.org/r/172590/#review177878

Looks perfect, great job.

I will put it through try and if we are green I will r+ it.

Comment 4

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8901105 [details]
Bug 1336934 - Added option to remove all session cookies for a specific domain

https://reviewboard.mozilla.org/r/172590/#review177956

@Sebastian: There are some eslint failures... can you fix them?

devtools/client/storage/test/browser_storage_basic_usercontextid_1.js:29:1 | Line 29 exceeds the maximum line length of 90. (max-len)
devtools/client/storage/test/browser_storage_basic_with_fragment.js:47:1 | Line 47 exceeds the maximum line length of 90. (max-len)
devtools/client/storage/test/browser_storage_delete_usercontextid.js:47:1 | Line 47 exceeds the maximum line length of 90. (max-len)

Comment 5

[Sebastian Zartner [:sebo]]

Attachment: Bug 1336934 - Added option to remove all session cookies for a specific domain

Review commit: https://reviewboard.mozilla.org/r/172844/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/172844/

Comment 6

[Sebastian Zartner [:sebo]]

Thanks for the very fast review, Mike! I've fixed the ESLint failures.

Sebastian

Comment 7

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

(In reply to Sebastian Zartner [:sebo] from comment #6)
> Thanks for the very fast review, Mike! I've fixed the ESLint failures.
> 
> Sebastian

No problem... I will run it through try again but I don't expect any problems.

Comment 8

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

You have submitted two commits, which doesn't work with our automated try and landing.

Can you merge the two commits and push them again? Thx.

Comment 9

[Sebastian Zartner [:sebo]]

Comment on attachment 8901105 [details]
Bug 1336934 - Added option to remove all session cookies for a specific domain

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/172590/diff/1-2/

Comment 10

[Sebastian Zartner [:sebo]]

I pushed a merged commit to review. Hopefully I did it right this time!

Sebastian

Comment 11

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

(In reply to Sebastian Zartner [:sebo] from comment #10)
> I pushed a merged commit to review. Hopefully I did it right this time!
> 
> Sebastian

Yup, that is perfect.

Comment 12

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8901105 [details]
Bug 1336934 - Added option to remove all session cookies for a specific domain

https://reviewboard.mozilla.org/r/172590/#review179094

Comment 13

[Sebastian Zartner [:sebo]]

Thank you for the review, Mike! As I don't have rights to land the patch, I've set the 'checkin-needed' flag.

Sebastian

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/217f398fd59d
Added option to remove all session cookies for a specific domain r=miker

Comment 15

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/217f398fd59d

Comment 16

[Almas Hossain[:mAlmas]]

I have reproduced this bug with Nightly 55.0a1 (2017-02-06) in Windows 10 (64-bit).

This bug's fix is verified with latest Nightly 57.0a1 (64-bit).
 
Build ID   :   20170831100258
User Agent :   Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0

[bugday 20170830]