Closed Bug 1336934 Opened 3 years ago Closed 3 years ago

Allow to remove all session cookies of a website

Categories

(DevTools :: Storage Inspector, enhancement, P3)

53 Branch
enhancement

Tracking

(firefox57 fixed)

RESOLVED FIXED
Firefox 57
Tracking Status
firefox57 --- fixed

People

(Reporter: sebo, Assigned: sebo)

References

(Blocks 1 open bug)

Details

(Whiteboard: [todo-mr][t1])

Attachments

(1 file, 1 obsolete file)

The context menu within the cookies section of the Storage Inspector should provide an option to only delete session cookies like Firebug did it.

Sebastian
Filter on HOTFROG.
Whiteboard: [todo-mr] → [todo-mr][t1]
Assignee: nobody → sebastianzartner
Status: NEW → ASSIGNED
Comment on attachment 8901105 [details]
Bug 1336934 - Added option to remove all session cookies for a specific domain

https://reviewboard.mozilla.org/r/172590/#review177878

Looks perfect, great job.

I will put it through try and if we are green I will r+ it.
Comment on attachment 8901105 [details]
Bug 1336934 - Added option to remove all session cookies for a specific domain

https://reviewboard.mozilla.org/r/172590/#review177956

@Sebastian: There are some eslint failures... can you fix them?

devtools/client/storage/test/browser_storage_basic_usercontextid_1.js:29:1 | Line 29 exceeds the maximum line length of 90. (max-len)
devtools/client/storage/test/browser_storage_basic_with_fragment.js:47:1 | Line 47 exceeds the maximum line length of 90. (max-len)
devtools/client/storage/test/browser_storage_delete_usercontextid.js:47:1 | Line 47 exceeds the maximum line length of 90. (max-len)
Flags: needinfo?(sebastianzartner)
Thanks for the very fast review, Mike! I've fixed the ESLint failures.

Sebastian
Flags: needinfo?(sebastianzartner)
(In reply to Sebastian Zartner [:sebo] from comment #6)
> Thanks for the very fast review, Mike! I've fixed the ESLint failures.
> 
> Sebastian

No problem... I will run it through try again but I don't expect any problems.
You have submitted two commits, which doesn't work with our automated try and landing.

Can you merge the two commits and push them again? Thx.
Flags: needinfo?(sebastianzartner)
Attachment #8901388 - Attachment is obsolete: true
I pushed a merged commit to review. Hopefully I did it right this time!

Sebastian
Flags: needinfo?(sebastianzartner)
(In reply to Sebastian Zartner [:sebo] from comment #10)
> I pushed a merged commit to review. Hopefully I did it right this time!
> 
> Sebastian

Yup, that is perfect.
Comment on attachment 8901105 [details]
Bug 1336934 - Added option to remove all session cookies for a specific domain

https://reviewboard.mozilla.org/r/172590/#review179094
Attachment #8901105 - Flags: review?(mratcliffe) → review+
Thank you for the review, Mike! As I don't have rights to land the patch, I've set the 'checkin-needed' flag.

Sebastian
Keywords: checkin-needed
Pushed by mratcliffe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/217f398fd59d
Added option to remove all session cookies for a specific domain r=miker
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/217f398fd59d
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
I have reproduced this bug with Nightly 55.0a1 (2017-02-06) in Windows 10 (64-bit).

This bug's fix is verified with latest Nightly 57.0a1 (64-bit).
 
Build ID   :   20170831100258
User Agent :   Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0

[bugday 20170830]
Blocks: 1402485
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.