Closed Bug 1337001 Opened 5 years ago Closed 3 years ago

Provide path and query components to non-https URLs

Categories

(WebExtensions :: Request Handling, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: mattw, Unassigned)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [proxy] triaged)

The path and query components should only be stripped for https:// URLs, and only when the preference network.proxy.autoconfig_url.include_path is set to false.

Reference: https://developer.mozilla.org/en-US/docs/Web/HTTP/Proxy_servers_and_tunneling/Proxy_Auto-Configuration_(PAC)_file#Parameters
webextensions: --- → ?
webextensions: ? → ---
Since our FindProxyForPAC() implementation is non-standard (see bug 1381290 and others), we should not fix this.

It is more useful for addons to have the entire URL at all times, rather than some of the URL sometimes and all of the URL at other times. Having the URL at all times is also analogous to what legacy addons had with nsIProtocolProxyFilter.applyFilter().

Since addons are trusted, there is no reason to hide path and query components or any other part of the URL from the addon. The stripping of this info for traditional, server-hosted PAC files may have had to do with security precautions. Since our FindProxyForPAC() is hosted within the locally-hosted addon itself, there's no added security risk by providing this info. Indeed, it is also available to the addon via webRequest API listeners.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → WONTFIX
Currently the path component of the URL isn't provided at all, and I think you're suggesting that it should be provided for all URLs, correct? If so, we would still have to make that change.
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
> I think you're suggesting that it should be provided for all URLs, correct

Yes. Do we need a new bug?
Priority: -- → P2
Could anyone points me how I may fix it? This bug makes my addon almost unusable. I would like to fix it myself if I could.
Priority: P2 → P3
Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 1409878
Product: Toolkit → WebExtensions
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Duplicate of this bug: 1494823

register is being deprecated, onRequest provides full details.

Status: REOPENED → RESOLVED
Closed: 4 years ago3 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.