1494823 - PAC scripts do not receive full url

Status: RESOLVED DUPLICATE of bug 1337001

(WebExtensions :: General, defect)

Description

[tdriley]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3497.100 Safari/537.36

Steps to reproduce:

Firefox Developer Edition 63.0b9 (64-bit)
Implement a PAC script in a Firefox Web Extension.
Look at the value of the 'url' arg inside the FindProxyForURL func (the only way to do this seems to be to send a message to another part of the extension which can console.log).



Actual results:

Any logic inside the PAC script which uses rules relating to paths will not work.


Expected results:

If the value of 'url' was a URL, functionality such as regex matching can be used in the PAC script logic. All other implementations of FindProxyForURL I have seen will provide this information in the url arg.

Comment 1

[Shane Caraveo (:mixedpuppy)]

I don't really understand what you are doing.  A small/simple extension illustrating the bug would help.  

It's useful to note that the "PAC" in our api is not really up to snuff with a PAC one would register in preferences.  If you need a real PAC file, you should set the autoConfigUrl[1].  If you need to be able to do custom logic in the extension, you should probably switch to using proxy.onRequest[2].

[1] https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/proxy/settings
[2] https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/proxy/onRequest

Comment 2

[tdriley]

(In reply to Shane Caraveo (:mixedpuppy) from comment #1)
> I don't really understand what you are doing.  A small/simple extension
> illustrating the bug would help.  
> 
> It's useful to note that the "PAC" in our api is not really up to snuff with
> a PAC one would register in preferences.  If you need a real PAC file, you
> should set the autoConfigUrl[1].  If you need to be able to do custom logic
> in the extension, you should probably switch to using proxy.onRequest[2].
> 
> [1]
> https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/
> proxy/settings
> [2]
> https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/
> proxy/onRequest

OK I was working on an extension I started last year before FF supported proxy.onRequest, so had been registering a PAC script[1]. If this is used for setting proxies, you will see the missing functionality I described above.

[1] https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/proxy/register